feat: remove plan command, add --plan flag and ResourceGraph toggle to deploy (#74)

* fix: remove plan command, add --plan flag to deploy

* feat: add toggleable ResourceGraph view to deploy (Ctrl+G)

* make ctrl+r description better

Author: notgitika

integ-tests/help.test.ts

@@ -7,7 +7,6 @@ const COMMANDS = [
   'dev',
   'invoke',
   'destroy',
-  'plan',
   'status',
   'validate',
   'add',

src/cli/cli.ts

@@ -8,7 +8,6 @@ import { registerEdit } from './commands/edit';
 import { registerInvoke } from './commands/invoke';
 import { registerOutline } from './commands/outline';
 import { registerPackage } from './commands/package';
-import { registerPlan } from './commands/plan';
 import { registerRemove } from './commands/remove';
 import { registerStatus } from './commands/status';
 import { registerStopSession } from './commands/stop-session';
@@ -112,7 +111,6 @@ export function registerCommands(program: Command) {
   registerInvoke(program);
   registerOutline(program);
   registerPackage(program);
-  registerPlan(program);
   registerRemove(program);
   registerStatus(program);
   registerStopSession(program);

src/cli/commands/deploy/actions.ts

@@ -19,6 +19,7 @@ export interface ValidatedDeployOptions {
   target: string;
   autoConfirm?: boolean;
   verbose?: boolean;
+  plan?: boolean;
   onProgress?: (step: string, status: 'start' | 'success' | 'error') => void;
   onResourceEvent?: (message: string) => void;
 }
@@ -125,6 +126,19 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
     }
     endStep('success');
 
+    // Plan mode: stop after synth and checks, don't deploy
+    if (options.plan) {
+      logger.finalize(true);
+      await toolkitWrapper.dispose();
+      toolkitWrapper = null;
+      return {
+        success: true,
+        targetName: target.name,
+        stackName,
+        logPath: logger.getRelativeLogPath(),
+      };
+    }
+
     // Set up identity providers if needed
     let identityKmsKeyArn: string | undefined;
     if (hasOwnedIdentityApiProviders(context.projectSpec)) {

src/cli/commands/deploy/command.tsx

@@ -72,6 +72,7 @@ async function handleDeployCLI(options: DeployOptions): Promise<void> {
     target: options.target!,
     autoConfirm: options.yes,
     verbose: options.verbose,
+    plan: options.plan,
     onProgress,
     onResourceEvent,
   });
@@ -84,22 +85,28 @@ async function handleDeployCLI(options: DeployOptions): Promise<void> {
   if (options.json) {
     console.log(JSON.stringify(result));
   } else if (result.success) {
-    console.log(`\n✓ Deployed to '${result.targetName}' (stack: ${result.stackName})`);
+    if (options.plan) {
+      console.log(`\n✓ Plan complete for '${result.targetName}' (stack: ${result.stackName})`);
+      console.log('\nRun `agentcore deploy` to deploy.');
+    } else {
+      console.log(`\n✓ Deployed to '${result.targetName}' (stack: ${result.stackName})`);
+
+      // Show stack outputs in non-JSON mode
+      if (result.outputs && Object.keys(result.outputs).length > 0) {
+        console.log('\nOutputs:');
+        for (const [key, value] of Object.entries(result.outputs)) {
+          console.log(`  ${key}: ${value}`);
+        }
+      }
 
-    // Show stack outputs in non-JSON mode
-    if (result.outputs && Object.keys(result.outputs).length > 0) {
-      console.log('\nOutputs:');
-      for (const [key, value] of Object.entries(result.outputs)) {
-        console.log(`  ${key}: ${value}`);
+      if (result.nextSteps && result.nextSteps.length > 0) {
+        console.log(`Next: ${result.nextSteps.join(' | ')}`);
       }
     }
 
     if (result.logPath) {
       console.log(`\nLog: ${result.logPath}`);
     }
-    if (result.nextSteps && result.nextSteps.length > 0) {
-      console.log(`Next: ${result.nextSteps.join(' | ')}`);
-    }
   } else {
     console.error(result.error);
     if (result.logPath) {
@@ -120,23 +127,26 @@ export const registerDeploy = (program: Command) => {
     .option('--progress', 'Show deployment progress in real-time')
     .option('-v, --verbose', 'Show resource-level deployment events')
     .option('--json', 'Output as JSON')
-    .action(async (cliOptions: { target?: string; yes?: boolean; progress?: boolean; json?: boolean }) => {
-      try {
-        requireProject();
-        if (cliOptions.json || cliOptions.target || cliOptions.progress) {
-          // Default to "default" target in CLI mode
-          const options = { ...cliOptions, target: cliOptions.target ?? 'default' };
-          await handleDeployCLI(options as DeployOptions);
-        } else {
-          handleDeployTUI({ autoConfirm: cliOptions.yes });
-        }
-      } catch (error) {
-        if (cliOptions.json) {
-          console.log(JSON.stringify({ success: false, error: getErrorMessage(error) }));
-        } else {
-          render(<Text color="red">Error: {getErrorMessage(error)}</Text>);
+    .option('--plan', 'Preview deployment without deploying (dry-run)')
+    .action(
+      async (cliOptions: { target?: string; yes?: boolean; progress?: boolean; json?: boolean; plan?: boolean }) => {
+        try {
+          requireProject();
+          if (cliOptions.json || cliOptions.target || cliOptions.progress || cliOptions.plan) {
+            // Default to "default" target in CLI mode
+            const options = { ...cliOptions, target: cliOptions.target ?? 'default' };
+            await handleDeployCLI(options as DeployOptions);
+          } else {
+            handleDeployTUI({ autoConfirm: cliOptions.yes });
+          }
+        } catch (error) {
+          if (cliOptions.json) {
+            console.log(JSON.stringify({ success: false, error: getErrorMessage(error) }));
+          } else {
+            render(<Text color="red">Error: {getErrorMessage(error)}</Text>);
+          }
+          process.exit(1);
         }
-        process.exit(1);
       }
-    });
+    );
 };

src/cli/commands/deploy/types.ts

@@ -4,6 +4,7 @@ export interface DeployOptions {
   progress?: boolean;
   verbose?: boolean;
   json?: boolean;
+  plan?: boolean;
 }
 
 export interface DeployResult {

src/cli/commands/index.ts

@@ -8,7 +8,6 @@ export { registerCreate } from './create';
 export { registerInvoke } from './invoke';
 export { registerOutline } from './outline';
 export { registerPackage } from './package';
-export { registerPlan } from './plan';
 export { registerRemove } from './remove';
 export { registerStatus } from './status';
 export { registerStopSession } from './stop-session';