Change variable name and add logging when using dualstack

Author: ShelbyZ

agent/ecr/factory.go

@@ -26,6 +26,7 @@ import (
 	"github.com/aws/amazon-ecs-agent/ecs-agent/credentials"
 	"github.com/aws/amazon-ecs-agent/ecs-agent/credentials/providers"
 	"github.com/aws/amazon-ecs-agent/ecs-agent/httpclient"
+	"github.com/aws/amazon-ecs-agent/ecs-agent/logger"
 	"github.com/aws/amazon-ecs-agent/ecs-agent/utils"
 
 	"github.com/aws/aws-sdk-go-v2/aws"
@@ -40,25 +41,25 @@ type ECRFactory interface {
 }
 
 type ecrFactory struct {
-	httpClient *http.Client
-	isIPv6Only bool
+	httpClient           *http.Client
+	useDualStackEndpoint bool
 }
 
 const (
 	roundtripTimeout = 5 * time.Second
 )
 
 // NewECRFactory returns an ECRFactory capable of producing ECRSDK clients
-func NewECRFactory(acceptInsecureCert bool, isIPv6Only bool) ECRFactory {
+func NewECRFactory(acceptInsecureCert bool, useDualStackEndpoint bool) ECRFactory {
 	return &ecrFactory{
-		httpClient: httpclient.New(roundtripTimeout, acceptInsecureCert, agentversion.String(), config.OSType),
-		isIPv6Only: isIPv6Only,
+		httpClient:           httpclient.New(roundtripTimeout, acceptInsecureCert, agentversion.String(), config.OSType),
+		useDualStackEndpoint: useDualStackEndpoint,
 	}
 }
 
 // GetClient creates the ECR SDK client based on the authdata
 func (factory *ecrFactory) GetClient(authData *apicontainer.ECRAuthData) (ECRClient, error) {
-	clientConfig, err := getClientConfig(factory.httpClient, authData, factory.isIPv6Only)
+	clientConfig, err := getClientConfig(factory.httpClient, authData, factory.useDualStackEndpoint)
 	if err != nil {
 		return &ecrClient{}, err
 	}
@@ -67,15 +68,16 @@ func (factory *ecrFactory) GetClient(authData *apicontainer.ECRAuthData) (ECRCli
 }
 
 // getClientConfig returns the config for the ecr client based on authData
-func getClientConfig(httpClient *http.Client, authData *apicontainer.ECRAuthData, isIPv6Only bool) (*aws.Config, error) {
+func getClientConfig(httpClient *http.Client, authData *apicontainer.ECRAuthData, useDualStackEndpoint bool) (*aws.Config, error) {
 	opts := []func(*awsconfig.LoadOptions) error{
 		awsconfig.WithRegion(authData.Region),
 		awsconfig.WithHTTPClient(httpClient),
 	}
 
 	if authData.EndpointOverride != "" {
 		opts = append(opts, awsconfig.WithBaseEndpoint(utils.AddScheme(authData.EndpointOverride)))
-	} else if isIPv6Only {
+	} else if useDualStackEndpoint {
+		logger.Debug("Configuring ECR Client DualStack endpoint")
 		opts = append(opts, awsconfig.WithUseDualStackEndpoint(aws.DualStackEndpointStateEnabled))
 	}