Skip to content

Commit c0a198d

Browse files
author
Tarun Belani
committed
Resolve merge conflicts
1 parent 6e3c2cc commit c0a198d

File tree

6 files changed

+24
-3
lines changed

6 files changed

+24
-3
lines changed

packages/@aws-cdk/aws-imagebuilder-alpha/lib/container-recipe.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { propertyInjectable } from 'aws-cdk-lib/core/lib/prop-injectable';
99
import { Construct } from 'constructs';
1010
import { BaseContainerImage, ContainerInstanceImage } from './base-image';
1111
import { Repository } from './distribution-configuration';
12+
import { IImageRecipe } from './image-recipe';
1213
import { OSVersion } from './os-version';
1314
import { ComponentConfiguration, IRecipeBase } from './recipe-base';
1415

@@ -378,6 +379,15 @@ export abstract class ContainerRecipeBase extends cdk.Resource implements IConta
378379
public _isContainerRecipe(): this is IContainerRecipe {
379380
return true;
380381
}
382+
383+
/**
384+
* Indicates whether the recipe is an Image Recipe
385+
*
386+
* @internal
387+
*/
388+
public _isImageRecipe(): this is IImageRecipe {
389+
return false;
390+
}
381391
}
382392

383393
/**

packages/@aws-cdk/aws-imagebuilder-alpha/lib/image-recipe.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { CfnImageRecipe } from 'aws-cdk-lib/aws-imagebuilder';
55
import { propertyInjectable } from 'aws-cdk-lib/core/lib/prop-injectable';
66
import { Construct } from 'constructs';
77
import { BaseImage } from './base-image';
8+
import { IContainerRecipe } from './container-recipe';
89
import { ComponentConfiguration, IRecipeBase } from './recipe-base';
910

1011
const IMAGE_RECIPE_SYMBOL = Symbol.for('@aws-cdk/aws-imagebuilder-alpha.ImageRecipe');
@@ -204,6 +205,15 @@ abstract class ImageRecipeBase extends cdk.Resource implements IImageRecipe {
204205
return this.grant(grantee, 'imagebuilder:GetImageRecipe');
205206
}
206207

208+
/**
209+
* Indicates whether the recipe is a Container Recipe
210+
*
211+
* @internal
212+
*/
213+
public _isContainerRecipe(): this is IContainerRecipe {
214+
return false;
215+
}
216+
207217
/**
208218
* Indicates whether the recipe is an Image Recipe
209219
*

packages/@aws-cdk/aws-imagebuilder-alpha/lib/recipe-base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export interface IRecipeBase extends cdk.IResource {
7070
* @internal
7171
*/
7272
_isContainerRecipe(): this is IContainerRecipe;
73-
73+
7474
/**
7575
* Indicates whether the recipe is an Image Recipe
7676
*

packages/@aws-cdk/aws-imagebuilder-alpha/test/base-image.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as cdk from 'aws-cdk-lib';
2+
import * as ecr from 'aws-cdk-lib/aws-ecr';
23
import * as ssm from 'aws-cdk-lib/aws-ssm';
34
import { BaseContainerImage, BaseImage, ContainerInstanceImage } from '../lib';
45

packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.asset.container-recipe.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ new imagebuilder.ContainerRecipe(stack, 'ContainerRecipe', {
1919
),
2020
});
2121

22-
new integ.IntegTest(app, 'ContainerRecipeTest', {
22+
new integ.IntegTest(app, 'ContainerRecipeTest-Asset', {
2323
testCases: [stack],
2424
});

packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.s3.container-recipe.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ new imagebuilder.ContainerRecipe(stack, 'ContainerRecipe', {
2020
dockerfile: imagebuilder.DockerfileData.fromS3(asset.bucket, asset.s3ObjectKey),
2121
});
2222

23-
new integ.IntegTest(app, 'ContainerRecipeTest', {
23+
new integ.IntegTest(app, 'ContainerRecipeTest-S3', {
2424
testCases: [stack],
2525
});

0 commit comments

Comments
 (0)