Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cloudfront_origins: OriginGroup support custom originId #31468

Open
1 of 2 tasks
vobarian opened this issue Sep 17, 2024 · 2 comments
Open
1 of 2 tasks

aws_cloudfront_origins: OriginGroup support custom originId #31468

vobarian opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
@aws-cdk/aws-cloudfront-origins Related to CloudFront Origins for the CDK CloudFront Library closing-soon This issue will automatically close in 4 days unless further comments are made. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@vobarian
Copy link

Describe the feature

OriginGroup does not appear to support setting an explicit originId currently. The auto-generated ID is very long and hard to read. We would like to set the originId as with other origin types such as HttpOrigin or RestApiOrigin.

Use Case

Create easy to read origin IDs for Origin Groups so we can more easily understand the configuration when looking at it in the CloudFront console.

Proposed Solution

Add originId to OriginGroupProps.

I might be able to implement this; I'm not very familiar with CDK internals but it seems that wherever the auto-generated ID is created, it could instead use the explicit prop if set. I could use a little hint on where this happens.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.158.0

Environment details (OS name and version, etc.)

macOS

@vobarian vobarian added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 17, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront-origins Related to CloudFront Origins for the CDK CloudFront Library label Sep 17, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 17, 2024
@khushail khushail self-assigned this Sep 17, 2024
@khushail
Copy link
Contributor

Hi @vobarian , thanks for reaching out.

Yes, it would be good to provide custom origin id in the origingroup.

This is cdk Code which implements OriginGroup

export class OriginGroup implements cloudfront.IOrigin {

and this is OriginGroupProps code reference -

Let me know if you need any more information. Thanks for volunteering for contribution!

@khushail khushail added p3 effort/small Small work item – less than a day of effort response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Sep 17, 2024
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront-origins Related to CloudFront Origins for the CDK CloudFront Library closing-soon This issue will automatically close in 4 days unless further comments are made. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants