Switch preliminary scale-all nodes attempt to be all-or-nothing

lukeseawalker · lukeseawalker · commit 0ad03a11e3fc · 2023-08-22T10:08:29.000+02:00
Optimize job level scaling with preliminary scale-all nodes attempt.
Switch this preliminary scaling from best-effort to all-or-nothing, so to remove unused instance launches

Signed-off-by: Luca Carrogu &lt;carrogu@amazon.com&gt;
diff --git a/src/slurm_plugin/instance_manager.py b/src/slurm_plugin/instance_manager.py
@@ -776,7 +776,7 @@ def _scaling_for_jobs_multi_node(
         self.unused_launched_instances |= self._launch_instances(
             nodes_to_launch=self._parse_requested_nodes(node_list),
             launch_batch_size=launch_batch_size,
-            all_or_nothing_batch=False,
+            all_or_nothing_batch=True,
         )
 
         self._scaling_for_jobs(

Original file line number	Diff line number	Diff line change
`@@ -776,7 +776,7 @@ def _scaling_for_jobs_multi_node(`
`776`	`776`	`self.unused_launched_instances \|= self._launch_instances(`
`777`	`777`	`nodes_to_launch=self._parse_requested_nodes(node_list),`
`778`	`778`	`launch_batch_size=launch_batch_size,`
`779`		`- all_or_nothing_batch=False,`
	`779`	`+ all_or_nothing_batch=True,`
`780`	`780`	`)`
`781`	`781`
`782`	`782`	`self._scaling_for_jobs(`