Commit 988f4c0
committed
feat: Add
This adds a new type called `viewId` which uniquely identifies
a part of the UI in an IDE window.
The `viewId` should be a comma delimited string where each item
appended is a more specific part of the UI within the previous
item.
The top level (first item) part of the string should be an identifier
for the specific IDE window, as it is possible to have multiple windows
of the same IDE opened at the same time. Then if there is a specific
view within that specific IDE window you would append its identifier.
Example:
- I have 2 VS Code windows with IDs: `abc-123` and `xyz-789`
- My Amazon Q chat view has an ID `amazonq-chat`
- Result `viewId`: `abc-123,amazonq-chat` and `xyz-789,amazonq-chat`
Now in my metrics I will be able to differentiate metrics by their viewId
since they both share the same clientId by design.
Signed-off-by: Nikolas Komonen <[email protected]>viewId common definition type1 parent cfc676d commit 988f4c0
File tree
3 files changed
+12
-0
lines changed- telemetry
- definitions
- vscode/src
3 files changed
+12
-0
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1681 | 1681 | | |
1682 | 1682 | | |
1683 | 1683 | | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
1684 | 1689 | | |
1685 | 1690 | | |
1686 | 1691 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
| |||
0 commit comments