fix(sagemaker): Improve SSH configuration error handling for SageMaker remote connections

bhavya2109sharma · bhavya2109sharma · commit 618470bd5524 · 2025-11-19T19:57:03.000-08:00
diff --git a/packages/core/src/awsService/sagemaker/commands.ts b/packages/core/src/awsService/sagemaker/commands.ts
@@ -231,7 +231,6 @@ export async function openRemoteConnect(
         if (shouldSuppressError(err)) {
             return
         }
-        throw err
     }
 }
 
diff --git a/packages/core/src/awsService/sagemaker/constants.ts b/packages/core/src/awsService/sagemaker/constants.ts
@@ -47,8 +47,8 @@ export const InstanceTypeNotSelectedMessage = (spaceName: string) => {
 export const RemoteAccessRequiredMessage =
     'This space requires remote access to be enabled.\nWould you like to restart the space and connect?\nAny unsaved work will be lost.'
 
-export const SshConfigErrorMessage = (sshConfigPath: string) => {
-    return `Unable to connect. ${sshConfigPath} contains SSH configuration syntax errors. Fix the errors to continue.`
+export const SshConfigErrorMessage = () => {
+    return `Unable to connect. ~/.ssh/config contains invalid SSH configuration. Fix the errors to continue.`
 }
 
 export const SmusDeeplinkSessionExpiredError = {
diff --git a/packages/core/src/awsService/sagemaker/model.ts b/packages/core/src/awsService/sagemaker/model.ts
@@ -101,12 +101,10 @@ export async function prepareDevEnvConnection(
         if (err instanceof ToolkitError && err.code === 'SshCheckFailed') {
             const sshConfigPath = path.join(os.homedir(), '.ssh', 'config')
 
+            // Extracting line number from SSH error message is the best-effort.
+            // SSH error formats are not standardized and may vary across implementations.
             await vscode.window
-                .showErrorMessage(
-                    SshConfigErrorMessage(sshConfigPath),
-                    { modal: true, detail: err.message },
-                    'Open SSH Config'
-                )
+                .showErrorMessage(SshConfigErrorMessage(), { modal: true, detail: err.message }, 'Open SSH Config')
                 .then((resp) => {
                     if (resp === 'Open SSH Config') {
                         void vscode.window.showTextDocument(vscode.Uri.file(sshConfigPath))
diff --git a/packages/toolkit/.changes/next-release/Bug Fix-3550c6a1-d356-45cc-a404-c87e2d2ee393.json b/packages/toolkit/.changes/next-release/Bug Fix-3550c6a1-d356-45cc-a404-c87e2d2ee393.json
@@ -0,0 +1,4 @@
+{
+	"type": "Bug Fix",
+	"description": "SageMaker: Enhanced SSH configuration error handling to show user-friendly modal dialogs with line numbers and an \"Open SSH Config\" button for quick fixes."
+}

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,6 @@ export async function openRemoteConnect(`
`231`	`231`	`if (shouldSuppressError(err)) {`
`232`	`232`	`return`
`233`	`233`	`}`
`234`		`- throw err`
`235`	`234`	`}`
`236`	`235`	`}`
`237`	`236`
Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,8 @@ export const InstanceTypeNotSelectedMessage = (spaceName: string) => {`
`47`	`47`	`export const RemoteAccessRequiredMessage =`
`48`	`48`	`'This space requires remote access to be enabled.\nWould you like to restart the space and connect?\nAny unsaved work will be lost.'`
`49`	`49`
`50`		`-export const SshConfigErrorMessage = (sshConfigPath: string) => {`
`51`		- return `Unable to connect. ${sshConfigPath} contains SSH configuration syntax errors. Fix the errors to continue.`
	`50`	`+export const SshConfigErrorMessage = () => {`
	`51`	+ return `Unable to connect. ~/.ssh/config contains invalid SSH configuration. Fix the errors to continue.`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`export const SmusDeeplinkSessionExpiredError = {`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +	"type": "Bug Fix",
 +	"description": "SageMaker: Enhanced SSH configuration error handling to show user-friendly modal dialogs with line numbers and an \"Open SSH Config\" button for quick fixes."
 +}