Fixed default vs code smoke tests for sagemaker E2E testing #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinh-amazon
approved these changes
Nov 26, 2025
|
|
||
| -const CONTRIBUTED_PROFILE_NAME = `JavaScript Debug Terminal`; | ||
| -const ANY_PROFILE_NAME = '^((?!JavaScript Debug Terminal).)*$'; | ||
| +const CONTRIBUTED_PROFILE_NAME = `sh`; |
Contributor
There was a problem hiding this comment.
Nit: This is just for SageMaker, let's add this as a comment that we will need to change this for different integrators.
Contributor
There was a problem hiding this comment.
Can be fixed in a later PR.
|
|
||
| const userDataDir = path.join(testDataPath, 'd'); | ||
|
|
||
| -async function setupRepository(): Promise<void> { |
Contributor
There was a problem hiding this comment.
Let's create a task to also rebase test patches in the update automation workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
D348189549
Description of Changes
patches/test/sagemaker/fix-smoke-tests.diffpatch).beforeAllandafterAllintest/smoke/src/main.tsbecause we do the equivalent with playwright when accessing the sagemaker code editor space (in thepatches/test/sagemaker/sagemaker-smoke-testing-entry.diffpatch).Testing
Screenshots/Videos
N/A
Additional Notes
N/A
Backporting
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.