Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new ECR endpoints to EKS ECR credential provider config #2082

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

BDworak
Copy link
Contributor

@BDworak BDworak commented Dec 6, 2024

Issue #, if available:

Description of changes:
Add new upcoming ECR endpoints to EKS ECR Credential provider configuration json.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done
No testing, this is just a configuration update.

@cartermckinnon
Copy link
Member

/ci

Copy link
Contributor

github-actions bot commented Dec 6, 2024

@cartermckinnon roger that! I've dispatched a workflow. 👍

@kattmang
Copy link

kattmang commented Dec 6, 2024

ECR SDE lead for IPv6 checking in: LGTM, thanks.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

@cartermckinnon the workflow that you requested has completed. 🎉

AMI variantBuildTest
1.24 / al2success ✅success ✅
1.24 / al2023success ✅success ✅
1.25 / al2success ✅success ✅
1.25 / al2023success ✅success ✅
1.26 / al2success ✅success ✅
1.26 / al2023success ✅success ✅
1.27 / al2success ✅success ✅
1.27 / al2023success ✅success ✅
1.28 / al2success ✅success ✅
1.28 / al2023success ✅success ✅
1.29 / al2success ✅success ✅
1.29 / al2023success ✅success ✅
1.30 / al2success ✅success ✅
1.30 / al2023success ✅success ✅
1.31 / al2success ✅success ✅
1.31 / al2023success ✅success ✅

@BDworak
Copy link
Contributor Author

BDworak commented Dec 7, 2024

We should hold off on merging this PR until the cloud-provider-aws PR gets merged to maintain correct order of operations: kubernetes/cloud-provider-aws#1069.

@ndbaker1 ndbaker1 changed the title Add new ECR endpoints to EKS ECR credential provider config json feat: add new ECR endpoints to EKS ECR credential provider config Dec 16, 2024
@ndbaker1 ndbaker1 merged commit 131c287 into awslabs:main Dec 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants