-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: The receiveGstreamerAudioVideo don't work in the v1.11.0 #2076
Comments
Hi @linzhenggang1, thanks for your concern. To get the audio to playback for the MasterGstSample, you can add the following to https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/blob/v1.11.0/samples/kvsWebrtcClientMasterGstSample.c#L392: + pSampleConfiguration->receiveAudioVideoSource = receiveGstreamerAudioVideo;
- pSampleConfiguration->mediaType = SAMPLE_STREAMING_VIDEO_ONLY;
+ pSampleConfiguration->mediaType = SAMPLE_STREAMING_AUDIO_VIDEO; |
@sirknightj I found it from your URL link https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/compare/v1.10.1..v1.11.0. Maybe you have to click "Load diff" on the kvsWebrtcClientMasterGstSample.c section. |
HI @linzhenggang1, thanks for the clarification. I traced back the change to this pull request: #1972, which indicates it was removed intentionally due to issues encountered with the video track. Are the changes I suggested above working for you to enable the audio playback you're looking for? |
Hi @sirknightj I tied the source code you suggested above in v1.11.0 and v1.10.2, but they didn't work and even didn't accept a CTRL + C command. In addition, the v1.10.1 is working well in my environment. Is the v1.11.0 and v1.10.2 well working in your environment? When the receiveGstreamerAudioVideo thread does not work, the onGstAudioFrameReady function will never be called, so how will it play sounds? |
Please confirm you have already done the following
Please answer the following prompt
Describe the bug
When I ran the kvsWebrtcClientMasterGstSample, I found that it didn't play any audio.
I compared the source code of 1.10.1 and 1.11.0 and found that you deleted the code below in /samples/kvsWebrtcClientMasterGstSample.c from v1.11.0.
pSampleConfiguration->receiveAudioVideoSource = receiveGstreamerAudioVideo;
Is this a mistake?
If No, could you tell me how to make the kvsWebrtcClientMasterGstSample play audio from the remote peer?
Thank you.
Expected Behavior
The kvsWebrtcClientMasterGstSample plays audio from the remote peer.
(The receiveGstreamerAudioVideo task can run normally)
Current Behavior
The kvsWebrtcClientMasterGstSample doesn't play audio from the remote peer.
(The receiveGstreamerAudioVideo task doesn't run)
Reproduction Steps
WebRTC C SDK version being used
v1.11.0
If it was working in a previous version, which one?
1.10.1
Compiler and Version used
gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0
Operating System and version
Ubuntu 24
Platform being used
Linux
The text was updated successfully, but these errors were encountered: