`delete` fails when target branch name is a substring of another existing branch name

[adit-chandra]

Hi, we're running into an issue where we're trying to delete a branch say feature but we get a 404 ref not found error even though we know the ref exists and we can see the ref in s3.

Turns out that because we have two branches, feature and feature-A, the delete command logic returns a 404 because it matches on prefix only and finds that there are two refs.

Also not sure why resolving to 2 objects returns a 404 "{remote_ref} not found" instead of a 409 and/or a more descriptive error.

[massi-ang]

Hi @adit-chandra Can you share the steps to reproduce?

[adit-chandra]

Yep, steps to reproduce:

1. git checkout -b foo && git push
2. git checkout -b foo-bar && git push
3. git push --delete origin foo

You should then get the err:

...
 ! [remote rejected] foo (not found)
error: failed to push some refs to 's3://...'

But if you git push --delete origin foo-bar first, and run git push --delete origin foo afterwards, you don't run into any errs.

thankfully the fix seems as simple as appending a trailing forward slash to the s3 prefix. this also directly matches existing prefix construction for ListObjectsV2 calls used elsewhere in your library :)
#48