Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all models files are being written when all nodes have learnable embeddings #1162

Closed
thvasilo opened this issue Feb 12, 2025 · 2 comments
Assignees
Labels
bug Something isn't working sagemaker

Comments

@thvasilo
Copy link
Contributor

When training an LP model where all nodes have learnable embeddings (no features) on SageMaker, it seems like model files are not being saved for every epoch, although topk-model-to-save is left at its default value (inf)

Example output uploaded to S3:

    ── epoch-13
    │   ├── Actor
    │   ├── Director
    │   ├── Genre
    │   ├── Movie
    │   ├── Person
    │   └── User
    ├── epoch-14
    │   ├── Actor
    │   ├── Director
    │   ├── Genre
    │   ├── model.bin
    │   ├── Movie
    │   ├── optimizers.bin
    │   ├── Person
    │   └── User
    ├── epoch-15
    │   ├── Actor
    │   ├── Director
    │   ├── Genre
    │   ├── Movie
    │   ├── Person
    │   └── User
    ├── epoch-16
    │   ├── Actor
    │   ├── Director
    │   ├── Genre
    │   ├── Movie
    │   ├── Person
    │   └── User
    ├── epoch-17
    │   ├── Actor
    │   ├── Director
    │   ├── Genre
    │   ├── model.bin
    │   ├── Movie
    │   ├── optimizers.bin
    │   ├── Person
    │   └── User
    ├── epoch-18
    │   ├── Actor
    │   ├── Director
    │   ├── Genre
    │   ├── model.bin
    │   ├── Movie
    │   ├── optimizers.bin
    │   ├── Person
    │   └── User
    ├── epoch-19
    │   ├── Actor
    │   ├── Director
    │   ├── Genre
    │   ├── Movie
    │   ├── Person
    │   └── User
@thvasilo thvasilo added bug Something isn't working sagemaker labels Feb 12, 2025
@zhjwy9343
Copy link
Contributor

Hi, could you provide brief steps of reproducing this issue?

@thvasilo
Copy link
Contributor Author

I've tried to replicate this with a few configs on SageMaker but have not been successful. I'll close this and re-open if I encounter this again with a good way to replicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sagemaker
Projects
None yet
Development

No branches or pull requests

2 participants