refactor: add clippy pedantic lints

Author: axelkar

Cargo.lock

@@ -24,3 +24,15 @@ owo-colors = "4.0.0"
 parking_lot = "0.12.3"
 rayon = "1.10.0"
 logos = "0.14.1"
+
+[workspace.lints.rust]
+# https://github.com/rust-lang/rust/issues/95513
+#unused_crate_dependencies = "warn"
+unsafe_code = "deny" # Not in this project's scope currently
+
+[workspace.lints.clippy]
+pedantic = "warn"
+allow_attributes = "warn"
+allow_attributes_without_reason = "warn"
+should_panic_without_expect = "warn"
+match_wildcard_for_single_variants = { level = "allow", priority = 1 }

Cargo.toml

@@ -16,7 +16,6 @@ dt-diagnostic.workspace = true
 tracing.workspace = true # TODO: remove, this is only for debugging
 either = "1.10.0"
 serde_json = "1.0.114"
-serde_yaml = "0.9.33"
 thiserror = "1.0.57"
 vec1 = "1.10.1"
 rustc-hash.workspace = true
@@ -25,6 +24,10 @@ enum-as-inner = "0.6.0"
 derive_more = { version = "1.0.0", features = ["debug"] }
 
 [dev-dependencies]
+serde_yaml = "0.9.33"
 codespan-reporting = "0.11.1"
 owo-colors.workspace = true
 pretty_assertions.workspace = true
+
+[lints]
+workspace = true

crates/dt-analyzer/Cargo.toml

@@ -1,6 +1,6 @@
 //! Parses the file at argv 1 and prints the analyzed data as JSON
 //!
-//! Use `--assert` in argv[2] to pretty_assertions::assert_eq
+//! Use `--assert` in argv[2] to `pretty_assertions::assert_eq`
 
 use dt_parser::ast::SourceFile;
 use owo_colors::{colors::xterm::Gray, OwoColorize as _};
@@ -14,9 +14,9 @@ fn remove_first<T>(vec: &mut Vec<T>) -> Option<T> {
     Some(vec.swap_remove(0))
 }
 
-/// This should be more efficient than "re-serializing" serde_yaml::Value into serde_json::Value
+/// This should be more efficient than "re-serializing" `serde_yaml::Value` into `serde_json::Value`
 /// but more importantly, this never errors and skips tags (not the values though), because thay
-/// can't be represented as serde_json::Value
+/// can't be represented as `serde_json::Value`
 ///
 /// NOTE: this cuts out node children with the name phandle and returns `-1` for anything with the
 /// YAML tag `phandle` e.g. `!phandle 0x1`
@@ -157,10 +157,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         std::process::exit(1);
     };
 
-    if !assert {
-        eprintln!("DTC output: {}", serde_json::to_string(&dtc_json).unwrap());
-    } else {
+    if assert {
         pretty_assertions::assert_eq!(own_json, dtc_json);
+    } else {
+        eprintln!("DTC output: {}", serde_json::to_string(&dtc_json).unwrap());
     }
     eprintln!(
         "{}{:?}",

crates/dt-analyzer/examples/analyzer_json.rs

@@ -34,7 +34,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     vec.sort_by(|a, b| a.0.cmp(&b.0));
     for (name, value) in vec {
         let name = name.join("/");
-        eprintln!("{} -> {:#?}", name, value);
+        eprintln!("{name} -> {value:#?}");
     }
 
     if !parse.lex_errors.is_empty() || !parse.errors.is_empty() {

crates/dt-analyzer/examples/test_analyzer.rs

@@ -75,7 +75,7 @@ pub struct Label {
 ///
 /// See [crate root](crate).
 pub fn analyze_cst(file: &ast::SourceFile, src: &str) -> Option<FileDefinition> {
-    let root_node = file.nodes().find(|node| node.is_root())?;
+    let root_node = file.nodes().find(dt_parser::ast::DtNode::is_root)?;
     let extensions = file.nodes().filter(ast::DtNode::is_extension);
     // TODO: check includes for extension labels?
     let labels = {
@@ -94,25 +94,24 @@ pub fn analyze_cst(file: &ast::SourceFile, src: &str) -> Option<FileDefinition>
     // duplicate labels aren't allowed
     // labels can be used before and after their definition, without scope
 
-    let mut tree = analyze_node(root_node, src)?;
+    let mut tree = analyze_node(&root_node, src)?;
     for extension in extensions {
         // TODO: path-based phandles
         let label = extension.extension_name()?.name()?;
         let label = label.syntax().text().as_str();
 
-        let label = match labels.get(label) {
-            Some(labels) => labels,
-            None => {
-                tracing::warn!(
-                    "Couldn't find label {label} for extension at {:?}!",
-                    extension.syntax().text_range()
-                );
-                continue;
-            }
+        let label = if let Some(labels) = labels.get(label) {
+            labels
+        } else {
+            tracing::warn!(
+                "Couldn't find label {label} for extension at {:?}!",
+                extension.syntax().text_range()
+            );
+            continue;
         }
         .last()?;
 
-        let Some(ex_tree) = analyze_node(extension, src) else {
+        let Some(ex_tree) = analyze_node(&extension, src) else {
             continue;
         };
         let ex_tree = ex_tree.prefix(label.node_ast.path(src).map(Cow::into_owned));
@@ -125,6 +124,7 @@ pub fn analyze_cst(file: &ast::SourceFile, src: &str) -> Option<FileDefinition>
     })
 }
 
+#[must_use]
 pub fn find_labels<'i>(node: &ast::DtNode, src: &'i str) -> Vec<(&'i str, Label)> {
     node.label()
         .and_then(|label| {