Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] [UI] Icon discussion #1415

Open
CharlesChiuGit opened this issue Feb 3, 2025 · 3 comments
Open

[RFC] [UI] Icon discussion #1415

CharlesChiuGit opened this issue Feb 3, 2025 · 3 comments
Labels
enhancement New feature or request ui General user interface related issues

Comments

@CharlesChiuGit
Copy link
Collaborator

I found catppuccin/nvim have icon set in lsp_saga.lua.
I'm thinking maybe we can align our icon set to it, and we can just call

-- lua/modules/configs/completion/lspsaga.lua
require("modules.utils").load_plugin("lspsaga", {
		ui = {
			kind = require("catppuccin.groups.integrations.lsp_saga").custom_kind(),
		},
})

How do you guys think?

@ayamir
Copy link
Owner

ayamir commented Feb 5, 2025

But does this mean that users who use other themes will be unnecessarily affected?

@CharlesChiuGit
Copy link
Collaborator Author

CharlesChiuGit commented Feb 5, 2025

ah, let's true. i didn't think of that lol.
IMHO, i still think it would be nice to align the icon set, but keeping our lsp-saga config in the current way.

@Jint-lzxy
Copy link
Collaborator

IMHO, i still think it would be nice to align the icon set, but keeping our lsp-saga config in the current way.

Yesss agreed it's a bit all over the place lol would be so much cleaner if we align it esp w all those random magic wands showing up outta nowhere 🤣🤣

@Jint-lzxy Jint-lzxy changed the title [UI] icon discussion [RFC] [UI] Icon discussion Mar 3, 2025
@Jint-lzxy Jint-lzxy added enhancement New feature or request ui General user interface related issues labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui General user interface related issues
Projects
None yet
Development

No branches or pull requests

3 participants