Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated cover entity for curtains #134

Open
felipecrs opened this issue Oct 28, 2024 · 6 comments
Open

Duplicated cover entity for curtains #134

felipecrs opened this issue Oct 28, 2024 · 6 comments
Labels
Needs investigation Need investigation

Comments

@felipecrs
Copy link
Contributor

I have some smart curtains, and after configuring Extended Tuya, I now have a duplicated cover entity for each curtain.

image

xtend_tuya-01JB9SZWTKNX4C231MQ7VE2GBJ-Persiana Quarto Louise-e6388a415427618e4354a96c2d237a99.json

@felipecrs felipecrs changed the title Duplicated curtains Duplicated cover entity for curtains Oct 28, 2024
@azerty9971
Copy link
Owner

I feel someone is trying out the new WebRTC implementation :p
Please update to the latest beta that I just released as it contains the final touches for this to correctly work ;)

In the mean time for the curtain issue, can you try disabling the regular Tuya integration (just disable the config entry, no need to remove it) and let me know if it fixes the issue?

This is unfortunately a bug that is hard for me to trace because it doesn't happen to me when people share devices and I don't have it on my side when I enable both integrations :(.

Have a nice day,
Azerty

@felipecrs
Copy link
Contributor Author

I feel someone is trying out the new WebRTC implementation :p

lol, not yet, although I've came to know your integration thanks to AlexxIT/go2rtc#1412.

In the mean time for the curtain issue, can you try disabling the regular Tuya integration (just disable the config entry, no need to remove it) and let me know if it fixes the issue?

I am pretty sure it will fix the issue since one entity is provided by the official Tuya integration and another one is provided by Xtend Tuya. But I wanted to avoid doing that if possible.

image

This is unfortunately a bug that is hard for me to trace because it doesn't happen to me when people share devices and I don't have it on my side when I enable both integrations :(.

Oh, ok. Do you have any pointers in the code where you "de-duplicate" entities? I did not notice this behavior for almost a hundred other entities. I can try reviewing that logic myself.

@felipecrs
Copy link
Contributor Author

BTW, same behavior with v3.0.3-beta.1

@Effevi07
Copy link

Same problem with a Ketotek KTEM06, energy meter.
I see twice the instant power, but I cannot see any energy entity that was why I installed xtend Tuya.

@azerty9971
Copy link
Owner

Same problem with a Ketotek KTEM06, energy meter. I see twice the instant power, but I cannot see any energy entity that was why I installed xtend Tuya.

Hello,
Can you create a new issue regarding this and post the diagnostic file for that specific device? I'll do the implementation whenever I can ;)

@azerty9971
Copy link
Owner

azerty9971 commented Dec 13, 2024

For the blind, it's a tricky one, in fact Tuya has an implementation for it, but it was broken for some people so I made a second implementation in XT that works for them...
I'll need to fix it in the regular Tuya integration before doing the deduplication since otherwise people might have a broken entity... This is on my todo list...

In the mean time, you can disable the entity that doesn't work (or if both work then disable any of them).

Have a nice day,
Azerty

@azerty9971 azerty9971 added the Needs investigation Need investigation label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs investigation Need investigation
Projects
None yet
Development

No branches or pull requests

3 participants