Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preload: should delete container / fail gracefully if balena-image-preloader is in use #2657

Open
kendallgoto opened this issue Jul 21, 2023 · 0 comments

Comments

@kendallgoto
Copy link

Expected Behavior

balena preload should always succeed or fail gracefully if necessary

Actual Behavior

If balena preload runs and is interrupted unexpectedly, it leaves a container behind with a static name. Since it doesn't clean itself up, this then prevents balena preload from running again, since that static name is already taken:

(HTTP code 409) unexpected - Conflict. The container name "/balena-image-preloader" is already in use by container "..."

Instead, the service should either gracefully remove balena-image-preloader (if it is not really in use) or fail with a correlating error (i.e. if balena preload is actually running at the same time).

Steps to Reproduce the Problem

  1. run balena preload operation
  2. kill the balena task abruptly
  3. run balena preload again
  4. balena preload will fail, the balena-image-preloader will remain running and present until it is manually killed

Specifications

  • balena CLI 16.7.5
  • balenaCloud
  • 64bit linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant