fix: resolver to catch invalid resolutions

Author: barelyhuman

resolver/resolver.go

@@ -95,8 +95,7 @@ func (v *Resolver) ResolveVersion() (string, error) {
 		}
 
 		if len(proxyVersion.Version) == 0 {
-			fallbackVersion, err := v.GithubFallbackResolveVersion()
-			return fallbackVersion.Hash, err
+			return fallbackVersion.Hash, fallbackErr
 		}
 
 		// In case the value from the fallback (github's tag version )
@@ -141,6 +140,10 @@ func (v *Resolver) GithubFallbackResolveVersion() (PlumbingWithRange, error) {
 		version = v.Value
 	}
 
+	if len(parts) != 3 {
+		return PlumbingWithRange{}, fmt.Errorf("error, invalid resolution reference for github: %v, expected resolution reference to be like so: github.com/<org>/<repo>", v.Pkg)
+	}
+
 	resolvedV, err := gh.resolve(parts[1], parts[2], version)
 	if err != nil {
 		return PlumbingWithRange{}, err

resolver/resolver_test.go

@@ -130,6 +130,22 @@ func TestResolveVersionWithVersion(t *testing.T) {
 	}
 }
 
+func TestFallbackResolveVersionForInvalidPkg(t *testing.T) {
+	inputVersion := "0.0.7-dev.5"
+	r := Resolver{
+		Pkg: "github.com/barelyhuman",
+	}
+	err := r.ParseVersion(inputVersion)
+	if err != nil {
+		t.Fatalf("Failed to parse version, err:%v", err)
+	}
+
+	_, err = r.GithubFallbackResolveVersion()
+	if err == nil {
+		t.Fail()
+	}
+}
+
 func TestResolveVersionWithoutVersion(t *testing.T) {
 
 	inputVersion := ""