- Add start() bash function to wrap __complete, initialize and run`

Author: DannyBen

lib/bashly/libraries/settings/settings.yml

@@ -200,5 +200,6 @@ var_aliases:
 
 # Choose different names for some of the internal functions.
 function_names:
+  start: ~
   run: ~
   initialize: ~

lib/bashly/views/command/master_script.gtx

@@ -13,12 +13,14 @@
 = render :initialize
 = render :run
 
-> 
+>
+= render :start
+>
 if Settings.enabled? :sourcing
   > if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
-  = render(:start).indent 2
+  >   {{ Settings.function_name :start }} "$@"
   > fi
 else
-  = render :start
+  > {{ Settings.function_name :start }} "$@"
 end
-> 
+>

lib/bashly/views/command/start.gtx

@@ -1,14 +1,14 @@
 = view_marker
 
-> command_line_args=("$@")
+> {{ Settings.function_name :start }}() {
 if Settings.completions?
-> if [[ "${command_line_args[0]:-}" == "__complete" ]]; then
->   completion_run "${command_line_args[@]:1}"
-> else
+>   if [[ ${1:-} == "__complete" ]]; then
+>     completion_run "${@:2}"
+>     return
+>   fi
+end
+>
+>   command_line_args=("$@")
 >   {{ Settings.function_name :initialize }}
 >   {{ Settings.function_name :run }} "${command_line_args[@]}"
-> fi
-else
-> {{ Settings.function_name :initialize }}
-> {{ Settings.function_name :run }} "${command_line_args[@]}"
-end
+> }

schemas/settings.json

@@ -423,6 +423,19 @@
       "description": "Choose different names for some of the internal functions.\nhttps://bashly.dev/usage/settings/#function_names",
       "type": "object",
       "properties": {
+        "start": {
+          "title": "start",
+          "description": "Name for the start() function\nhttps://bashly.dev/usage/settings/#function_names",
+          "oneOf": [
+            {
+              "type": "string",
+              "minLength": 1
+            },
+            {
+              "type": "null"
+            }
+          ]
+        },
         "run": {
           "title": "run",
           "description": "Name for the run() function\nhttps://bashly.dev/usage/settings/#function_names",

spec/approvals/examples/stacktrace

@@ -52,4 +52,5 @@ Examples:
 Stack trace:
 	from ./download:<line> in `root_command`
 	from ./download:<line> in `run`
+	from ./download:<line> in `start`
 	from ./download:<line> in `main`

spec/bashly/script/wrapper_spec.rb

@@ -11,7 +11,7 @@
         lines = subject.code.split "\n"
         expect(lines[0..13].join("\n")).to match_approval('script/wrapper/code')
           .except(/\d+\.\d+\.\d+(\.rc\d)?/)
-        expect(lines[-3]).to eq '  run "${command_line_args[@]}"'
+        expect(lines).to include '  start "$@"'
       end
     end
 
@@ -42,5 +42,20 @@
         expect(lines[2]).to eq '# :command.root_command'
       end
     end
+
+    context 'with a custom start function name' do
+      around do |example|
+        original_function_names = Settings.function_names
+        Settings.function_names = { 'start' => 'custom_start' }
+        example.run
+      ensure
+        Settings.function_names = original_function_names
+      end
+
+      it 'uses the configured name for the definition and invocation' do
+        expect(subject.code).to include "custom_start() {\n"
+        expect(subject.code).to include "\n  custom_start \"$@\"\n"
+      end
+    end
   end
 end

spec/fixtures/completions/core/src/initialize.sh

@@ -0,0 +1,2 @@
+printf "initialize unexpectedly called\n"
+return 1

support/schema/settings.yml

@@ -348,6 +348,12 @@ properties:
       https://bashly.dev/usage/settings/#function_names
     type: object
     properties:
+      start:
+        title: start
+        description: |-
+          Name for the start() function
+          https://bashly.dev/usage/settings/#function_names
+        oneOf: *optional_string
       run:
         title: run
         description: |-