rubocop

Author: DannyBen

spec/bashly/completion_builder_spec.rb

@@ -1,8 +1,6 @@
 describe CompletionBuilder do
-  fixtures = load_fixture('completion_builder')
-
   describe '#call' do
-    fixtures.each do |fixture, options|
+    load_fixture('completion_builder').each do |fixture, options|
       context "with :#{fixture}" do
         let(:command) { Script::Command.new options['command'] }
         let(:builder) do
@@ -18,6 +16,7 @@
   end
 
   context 'with a default command' do
+    let(:fixtures) { load_fixture('completion_builder') }
     let(:command) { Script::Command.new fixtures[:default_command]['command'] }
     let(:data) { described_class.new(command).call }
 

spec/bashly/concerns/completions_command_spec.rb

@@ -3,6 +3,7 @@
 
   let(:fixtures) { load_fixture('script/commands') }
   let(:fixture) { :completions_simple }
+  let(:completion_generator) { instance_double Completely::Completions }
 
   describe '#completion_data' do
     it 'returns a data structure for completely' do
@@ -11,17 +12,16 @@
   end
 
   describe '#completion_function' do
-    it 'returns the generated bash completion script wrapped in a function' do
-      expected_data = subject.completion_data
-      completion_generator = instance_double Completely::Completions
-
-      expect(Completely::Completions).to receive(:new)
-        .with(expected_data)
+    before do
+      allow(Completely::Completions).to receive(:new)
+        .with(subject.completion_data)
         .and_return completion_generator
-      expect(completion_generator).to receive(:wrapper_function)
+      allow(completion_generator).to receive(:wrapper_function)
         .with('custom_name')
         .and_return 'wrapped completion script'
+    end
 
+    it 'returns the generated bash completion script wrapped in a function' do
       expect(subject.completion_function('custom_name'))
         .to eq 'wrapped completion script'
     end
@@ -38,16 +38,15 @@
     end
 
     describe '#completion_script' do
-      it 'returns the generated bash completion script' do
-        expected_data = subject.completion_data
-        completion_generator = instance_double Completely::Completions
-
-        expect(Completely::Completions).to receive(:new)
-          .with(expected_data)
+      before do
+        allow(Completely::Completions).to receive(:new)
+          .with(subject.completion_data)
           .and_return completion_generator
-        expect(completion_generator).to receive(:script)
+        allow(completion_generator).to receive(:script)
           .and_return 'completion script'
+      end
 
+      it 'returns the generated bash completion script' do
         expect(subject.completion_script)
           .to eq 'completion script'
       end

spec/bashly/libraries/completions_function_spec.rb

@@ -6,12 +6,16 @@
   before { reset_tmp_dir example: 'minimal' }
 
   describe '#files' do
-    it 'returns an array with a single hash' do
+    it 'returns one file at the default path' do
       files = subject.files
-      content = files.first[:content]
 
       expect(files.size).to eq 1
       expect(files.first[:path]).to eq "#{Settings.source_dir}/lib/send_completions.sh"
+    end
+
+    it 'returns the completions function content' do
+      content = subject.files.first[:content]
+
       expect(content).to include '## [@bashly-upgrade completions send_completions]'
       expect(content).to include 'send_completions() {'
       expect(content).to include 'generated by'

spec/bashly/libraries/completions_script_spec.rb

@@ -6,12 +6,16 @@
   before { reset_tmp_dir example: 'minimal' }
 
   describe '#files' do
-    it 'returns an array with a single hash' do
+    it 'returns one file at the default path' do
       files = subject.files
-      content = files.first[:content]
 
       expect(files.size).to eq 1
       expect(files.first[:path]).to eq "#{Settings.target_dir}/completions.bash"
+    end
+
+    it 'returns the completions script content' do
+      content = subject.files.first[:content]
+
       expect(content).to include '# download completion'
       expect(content).to include 'generated by'
       expect(content).to include 'completely'