avoid offering wildcard aliases as completions

Author: DannyBen

lib/bashly/script/introspection/commands.rb

@@ -41,6 +41,11 @@ def command_names
           commands.map(&:name)
         end
 
+        # Returns command names and aliases that can be offered as completions
+        def completion_aliases
+          public_commands.flat_map(&:aliases).reject { |name| name.end_with? '*' }
+        end
+
         # Returns an array of the Commands
         def commands
           return [] unless options['commands']

lib/bashly/views/command/completion_command_candidates.gtx

@@ -1,3 +1,3 @@
-if public_command_aliases.any?
-  > completion_candidates "$completion_current" {{ public_command_aliases.join ' ' }}
+if completion_aliases.any?
+  > completion_candidates "$completion_current" {{ completion_aliases.join ' ' }}
 end

spec/bashly/script/introspection/commands_spec.rb

@@ -52,6 +52,14 @@
     end
   end
 
+  describe '#completion_aliases' do
+    let(:fixture) { :completion_aliases }
+
+    it 'returns public command aliases without wildcard aliases' do
+      expect(subject.completion_aliases).to eq %w[download d upload]
+    end
+  end
+
   describe '#commands' do
     let(:fixture) { :docker }
 

spec/fixtures/completions/core/src/bashly.yml

@@ -37,6 +37,7 @@ commands:
     alias: down
     help: Stop a server
   - name: status
+    alias: stat*
     help: Show server status
 
 - name: config

spec/fixtures/script/commands.yml

@@ -8,6 +8,15 @@
   - name: update
     alias: upgrade
 
+:completion_aliases:
+  name: cli
+  commands:
+  - name: download
+    alias: [d, down*]
+  - name: upload
+  - name: internal
+    private: true
+
 :basic_command:
   name: get
   alias: g