Skip to content

Commit 06a20ad

Browse files
author
Doug Rohrer
committed
Post-2.0 merge cleanup after review of changes.
1 parent 2396709 commit 06a20ad

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

docs/ring-resizing.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,16 @@ isn't implicitly enlarged during the transition, it is not used during expansion
243243
One other minor change made to the vnode interface, regardless of
244244
whether or not resizing is being used, is the first argument
245245
of `handoff_starting/2` is now passed as `{HOType, {Idx, Node}}`.
246-
`HOType` is one of `ownership`, `hinted`, `resize`, or `repair`.
246+
`HOType` is one of `ownership`, `hinted`, or `resize`.
247247
The `Idx` being transferred to is always the index
248248
of the current partition, except in the case of `resize`.
249249
`Node` is the node being transferred to (this used to be the argument
250250
passed into `handoff_starting/2`).
251251

252+
Note: `HOType` is of type `riak_core_handoff_manager:ho_type()`, which includes
253+
`repair`, but since repairs are started through a different code path it will
254+
never be passed to `handoff_starting/2`.
255+
252256
### Cleaning Up
253257

254258
To ensure data is not lost in the case the operation fails or is

src/riak_core_vnode_manager.erl

+1-1
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,7 @@ update_handoff(AllVNodes, Ring, CHBin, State) ->
715715
false ->
716716
[];
717717
{true, primary, TargetNode} ->
718-
[{{Mod, Idx}, {ownership_handoff, outbound, TargetNode}}];
718+
[{{Mod, Idx}, {ownership, outbound, TargetNode}}];
719719
{true, {fallback, _Node}, TargetNode} ->
720720
[{{Mod, Idx}, {hinted, outbound, TargetNode}}];
721721
{true, '$resize'=Action} ->

0 commit comments

Comments
 (0)