Skip to content

Commit 271ba09

Browse files
committed
update library... more strong typing and tests
1 parent 073e5f4 commit 271ba09

File tree

11 files changed

+228
-135
lines changed

11 files changed

+228
-135
lines changed

.travis.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,15 @@ php:
66
- 'nightly'
77

88
services:
9+
- docker
910
- memcached
1011

1112
matrix:
1213
allow_failures:
1314
- php: 'nightly'
1415

1516
before_script:
17+
- docker run -p 9000:9000 -p 8123:8123 -d --name clickhouse --ulimit nofile=262144:262144 yandex/clickhouse-server
1618
- pecl install pcov
1719
- phpenv config-rm xdebug.ini || echo "xdebug not available"
1820
- bash <(curl -s https://raw.githubusercontent.com/php-cache/cache/master/build/php/7.2/Memcached.sh)

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"name": "bavix/laravel-clickhouse",
3+
"description": "Eloquent model for ClickHouse",
34
"type": "library",
45
"license": "MIT",
56
"keywords": [

src/ClickHouseServiceProvider.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,7 @@ public function register(): void
2828
{
2929
$this->app->resolving('db', static function (DatabaseManager $db) {
3030
$db->extend('bavix::clickhouse', static function ($config, $name) {
31-
return new Connection(\array_merge($config, [
32-
'name' => $name,
33-
]));
31+
return new Connection(\array_merge($config, \compact('name')));
3432
});
3533
});
3634
}

src/Database/Connection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public function query()
1919
}
2020

2121
/**
22-
* @inheritDoc
22+
* @return Pdo
2323
*/
2424
public function getPdo()
2525
{

0 commit comments

Comments
 (0)