Allow an optional index of dep -> class to be created #1492
+865
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheister
reviewed
Dec 3, 2025
| @@ -0,0 +1,139 @@ | |||
| { | |||
| "__AUTOGENERATED_FILE_DO_NOT_MODIFY_THIS_FILE_MANUALLY": "THERE_IS_NO_DATA_ONLY_ZUUL", | |||
| "classes": { | |||
Collaborator
There was a problem hiding this comment.
Why doesn't this include all of the classes from
"androidx.compose.foundation:foundation-layout:1.5.0-beta01",
"androidx.annotation:annotation:1.6.0",
"com.squareup.okhttp3:okhttp:4.12.0",
"com.almworks.sqlite4java:libsqlite4java-linux-i386:1.0.392",
"androidx.fragment:fragment-ktx:1.6.1",
Collaborator
Author
There was a problem hiding this comment.
We only populate the classes dict when there are split packages. When there's no split package, we put the coordinates in the packages dict. That keeps the size of the index file down (for a large repo, if we listed all the classes the index file would be 12MB, with this approach it's down to 4MB, and the lock file is 2MB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides information that the java gazelle plugin will use to more accurately determine where to load dependencies from.
Note: the index file will be substantially larger than the lock file since it contains far more data (the name of every single top-level class in every dependency)