{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":222501365,"defaultBranch":"master","name":"rules_ios","ownerLogin":"bazel-ios","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-11-18T17:07:19.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/63882386?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726706300.0","currentOid":""},"activityList":{"items":[{"before":"4793515da6db721593c563cee3f0ced02ed942d9","after":null,"ref":"refs/heads/yuanfeng/remove-swift-info-passing-hmap","pushedAt":"2024-09-19T00:38:20.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"}},{"before":"b5efa1f9d693d039f376c53aee17003997c088a5","after":"9e72bb65c174fde7be8cb4c9efb3f532644acfe4","ref":"refs/heads/master","pushedAt":"2024-09-19T00:38:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Remove swift info provider creation inside hmap rule (#919)\n\nLast place that touched this code is on\r\nhttps://github.com/bazel-ios/rules_ios/pull/906where I thought it's\r\nimportant to construct SwiftInfo provider for hmap and add compilation\r\ncontext to pass the failing test.\r\nHowever that leads to a new\r\n[issue](https://github.com/bazel-ios/rules_ios/pull/916#pullrequestreview-2310552165)\r\nwith `docc_archive` rule with latest `rules_apple/rules_swift`. We\r\nrealized it's actually not needed to provide any SwiftInfo provider at\r\nall or it will \"confuse\" rules_swift/apple (since newer version starts\r\nto rely more on clang info from Swift info itself instead\r\n`apple_common.Objc`). Removing this also have the original failing test\r\npassing.\r\n\r\nTests done:\r\n- [x] my own downstream repo still builds fine.\r\n- [x] CI is green\r\n\r\nWill squash before merge as it contains already merged commits","shortMessageHtmlLink":"Remove swift info provider creation inside hmap rule (#919)"}},{"before":"d704f72b45756ee6d4bb9e521572ec83c33c3c98","after":null,"ref":"refs/heads/thiago/rules_swift_package_manager-1","pushedAt":"2024-09-18T23:47:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"}},{"before":"e74047fc846d240bd1b8ce32f5b457a35c5dbafe","after":"b5efa1f9d693d039f376c53aee17003997c088a5","ref":"refs/heads/master","pushedAt":"2024-09-18T23:47:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Relanding of `Add swift.experimental_rules_swift_package_manager flag` back to master branch (#922)\n\nalready approved at https://github.com/bazel-ios/rules_ios/pull/917\r\n\r\nNow it's about landing it in master and since it is guarded by a flag,\r\nit's no op unless you enable this feature\r\n\r\nCo-authored-by: Thiago Cruz \r\nCo-authored-by: Jonathan Schear ","shortMessageHtmlLink":"Relanding of `Add swift.experimental_rules_swift_package_manager flag…"}},{"before":"72ba0cfb7c58c1457b37d1e282600450e943b8bb","after":"d704f72b45756ee6d4bb9e521572ec83c33c3c98","ref":"refs/heads/thiago/rules_swift_package_manager-1","pushedAt":"2024-09-18T19:13:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Add swift.experimental_rules_swift_package_manager flag\n\nCo-authored-by: Jonathan Schear ","shortMessageHtmlLink":"Add swift.experimental_rules_swift_package_manager flag"}},{"before":null,"after":"72ba0cfb7c58c1457b37d1e282600450e943b8bb","ref":"refs/heads/thiago/rules_swift_package_manager-1","pushedAt":"2024-09-18T19:10:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Fix typo\n\nCo-authored-by: Jonathan Schear ","shortMessageHtmlLink":"Fix typo"}},{"before":"bbf9e461ea93dd2f2bbc6af17735ba40239d3fb1","after":"ff2e2396421be9187df59a0e5a99ed299566ab42","ref":"refs/heads/luis/add-dir-output-test","pushedAt":"2024-09-18T17:29:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"luispadron","name":"Luis Padron","path":"/luispadron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13840545?s=80&v=4"},"commit":{"message":"Add test showcasing issue with directory inputs","shortMessageHtmlLink":"Add test showcasing issue with directory inputs"}},{"before":null,"after":"bbf9e461ea93dd2f2bbc6af17735ba40239d3fb1","ref":"refs/heads/luis/add-dir-output-test","pushedAt":"2024-09-18T17:17:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"luispadron","name":"Luis Padron","path":"/luispadron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13840545?s=80&v=4"},"commit":{"message":"Add test showcasing issue with directory inputs","shortMessageHtmlLink":"Add test showcasing issue with directory inputs"}},{"before":null,"after":"8ce64191b8a3d3e0f0a9e5c26926300fed50ae5a","ref":"refs/heads/yuanfeng/hmap-plus-spm-fix","pushedAt":"2024-09-18T13:41:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Merge commit 'c3486618327167e1fdd68f062756d902528db15c' of github.com:bazel-ios/rules_ios into yuanfeng/hmap-plus-spm-fix","shortMessageHtmlLink":"Merge commit 'c3486618327167e1fdd68f062756d902528db15c' of github.com…"}},{"before":"afb817944c392a3457f244fc544c23950aa3a77c","after":"4793515da6db721593c563cee3f0ced02ed942d9","ref":"refs/heads/yuanfeng/remove-swift-info-passing-hmap","pushedAt":"2024-09-18T13:37:58.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Merge branch 'master' into yuanfeng/remove-swift-info-passing-hmap","shortMessageHtmlLink":"Merge branch 'master' into yuanfeng/remove-swift-info-passing-hmap"}},{"before":"f61af307f347e8a27dcf21035967f81b3d837538","after":null,"ref":"refs/heads/yuanfeng/fix-missing-docc-provider","pushedAt":"2024-09-18T13:26:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"}},{"before":"6c6d621dfe8784f99a0eddaee94bb22a823503b0","after":"e74047fc846d240bd1b8ce32f5b457a35c5dbafe","ref":"refs/heads/master","pushedAt":"2024-09-18T13:26:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Merge clang/swift modules into one `direct_module` in SwiftInfo for a framework (#916)\n\n### What changed:\r\nRework of `_get_merged_swift_info` by bubble up the creation of clang\r\nmodule to `_apple_framework_packaging_impl` level, where it determine\r\nhow to populate the clang module based on VFS feature on/off.\r\nRemove the need to pass `virtualize_frameworks` flag to the private\r\nmethod `_get_merged_swift_info`\r\n\r\n### Why this change\r\nadd `fail(swift_info.direct_modules)` after creation of it at the end of\r\nthe packging impl method when running `bazel build\r\n//tests/ios/frameworks/testonly/... --config=ios --config=vfs`, you get\r\n```\r\n[\r\nstruct(\r\nclang = struct(compilation_context = , module_map = None, precompiled_module = None), compilation_context = None, is_system = False, name = \"SwiftLibrary\", \r\nswift = None),\r\n\r\n struct(\r\n clang = None, compilation_context = None, is_system = False, name = \"SwiftLibrary\",\r\n swift = struct(ast_files = (), defines = (), indexstore = None, plugins = [], private_swiftinterface = None, swiftdoc = , swiftinterface = None, swiftmodule = , swiftsourceinfo = None, symbol_graph = None))\r\n]\r\n```\r\nwith the current impl in `master` branch. Note that for the same module\r\n`SwiftLibrary`, there are two structs representing it, one has clang and\r\nno swift, and one has swift and nothing inside `clang`.\r\n\r\nSo this PR effectively merge two, but the clang module generation differ\r\nbased on VFS turn on or not:\r\nwith VFS on:\r\n```\r\n[struct(\r\n clang = struct(compilation_context = , module_map = None, precompiled_module = None), compilation_context = None, is_system = False, name = \"SwiftLibrary\", swift = None), struct(clang = None, compilation_context = None, is_system = False, name = \"SwiftLibrary\", \r\n \r\n swift = struct(ast_files = (), defines = (), indexstore = None, plugins = [], private_swiftinterface = None, swiftdoc = , swiftinterface = None, swiftmodule = , swiftsourceinfo = None, symbol_graph = None))\r\n]\r\n```\r\nwith VFS off:\r\n```\r\n[struct(\r\n\r\nclang = struct(compilation_context = , module_map = , precompiled_module = None), compilation_context = None, is_system = False, name = \"SwiftLibrary\", \r\n\r\nswift = struct(ast_files = (), defines = (), indexstore = None, plugins = [], private_swiftinterface = None, swiftdoc = , swiftinterface = None, swiftmodule = , swiftsourceinfo = None, symbol_graph = None))\r\n]\r\n```\r\nThis way we now have one direct_module instead of two representing the\r\nsame `SwiftLIbrary` module. This is important when trying to collect\r\nproviders for `docc_archive` rule on rules_apple side as otherwise we\r\nface `in dep attribute of docc_archive rule :\r\n'' does not have mandatory providers: 'DocCBundleInfo' or\r\n'DocCSymbolGraphsInfo'.` error.\r\n\r\n### Tests done\r\n1. tested with downstream big repo's full CI job (which has VFS on +\r\nbazel version 7.2.0)\r\n2. CI job itself being green","shortMessageHtmlLink":"Merge clang/swift modules into one direct_module in SwiftInfo for a…"}},{"before":"c62bd02e81d4d6c319c584a71ae164acc27aa159","after":null,"ref":"refs/heads/fix-ci-job-concurrency","pushedAt":"2024-09-18T01:08:41.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mattrobmattrob","name":"Matt Robinson","path":"/mattrobmattrob","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5728070?s=80&v=4"}},{"before":"cf6010570f85d633b643027d43821b477737421c","after":"6c6d621dfe8784f99a0eddaee94bb22a823503b0","ref":"refs/heads/master","pushedAt":"2024-09-18T01:08:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mattrobmattrob","name":"Matt Robinson","path":"/mattrobmattrob","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5728070?s=80&v=4"},"commit":{"message":"Fix new PR cancel previous PR's workflow (#918)\n\nsee\r\nhttps://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs#example-only-cancel-in-progress-jobs-on-specific-branches","shortMessageHtmlLink":"Fix new PR cancel previous PR's workflow (#918)"}},{"before":null,"after":"afb817944c392a3457f244fc544c23950aa3a77c","ref":"refs/heads/yuanfeng/remove-swift-info-passing-hmap","pushedAt":"2024-09-17T20:56:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Remove SwiftInfo creation inside hmap creation rule","shortMessageHtmlLink":"Remove SwiftInfo creation inside hmap creation rule"}},{"before":"652d89eba4354f1e8a1a38767eae1e5f72c427ee","after":"c62bd02e81d4d6c319c584a71ae164acc27aa159","ref":"refs/heads/fix-ci-job-concurrency","pushedAt":"2024-09-17T20:55:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Update tests.yml","shortMessageHtmlLink":"Update tests.yml"}},{"before":"9c421cdfc3b13537a707a7a9524d21235dff2aa4","after":"652d89eba4354f1e8a1a38767eae1e5f72c427ee","ref":"refs/heads/fix-ci-job-concurrency","pushedAt":"2024-09-17T20:51:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Update tests.yml","shortMessageHtmlLink":"Update tests.yml"}},{"before":null,"after":"9c421cdfc3b13537a707a7a9524d21235dff2aa4","ref":"refs/heads/fix-ci-job-concurrency","pushedAt":"2024-09-17T20:06:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Fix new PR cancel previous PR's workflow","shortMessageHtmlLink":"Fix new PR cancel previous PR's workflow"}},{"before":"72ba0cfb7c58c1457b37d1e282600450e943b8bb","after":null,"ref":"refs/heads/thiago/rules_swift_package_manager-1","pushedAt":"2024-09-17T20:05:03.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"thiagohmcruz","name":"Thiago Cruz","path":"/thiagohmcruz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10197663?s=80&v=4"}},{"before":"586be2f9c13b28c44650f001fe066800f1e1f5a3","after":"c3486618327167e1fdd68f062756d902528db15c","ref":"refs/heads/cshi/vfsoverlay-fix","pushedAt":"2024-09-17T20:05:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"thiagohmcruz","name":"Thiago Cruz","path":"/thiagohmcruz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10197663?s=80&v=4"},"commit":{"message":"Add swift.experimental_rules_swift_package_manager flag (#917)\n\nCo-authored-by: Jonathan Schear ","shortMessageHtmlLink":"Add swift.experimental_rules_swift_package_manager flag (#917)"}},{"before":"751d6f55a27cf4f64e781355035fea1603796e29","after":"72ba0cfb7c58c1457b37d1e282600450e943b8bb","ref":"refs/heads/thiago/rules_swift_package_manager-1","pushedAt":"2024-09-17T18:03:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"thiagohmcruz","name":"Thiago Cruz","path":"/thiagohmcruz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10197663?s=80&v=4"},"commit":{"message":"Fix typo\n\nCo-authored-by: Jonathan Schear ","shortMessageHtmlLink":"Fix typo"}},{"before":"a6bbd4725c0f865a1c0e94ff038060a50420de9f","after":"751d6f55a27cf4f64e781355035fea1603796e29","ref":"refs/heads/thiago/rules_swift_package_manager-1","pushedAt":"2024-09-17T15:10:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"thiagohmcruz","name":"Thiago Cruz","path":"/thiagohmcruz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10197663?s=80&v=4"},"commit":{"message":"Add swift.experimental_rules_swift_package_manager flag","shortMessageHtmlLink":"Add swift.experimental_rules_swift_package_manager flag"}},{"before":"0a19e1cec66d2f1f52147c2b966c4fe645d17332","after":"f61af307f347e8a27dcf21035967f81b3d837538","ref":"refs/heads/yuanfeng/fix-missing-docc-provider","pushedAt":"2024-09-17T14:34:12.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Move clang module creation to top level","shortMessageHtmlLink":"Move clang module creation to top level"}},{"before":null,"after":"0a19e1cec66d2f1f52147c2b966c4fe645d17332","ref":"refs/heads/yuanfeng/fix-missing-docc-provider","pushedAt":"2024-09-16T21:17:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"gyfelton","name":"Elton Gao","path":"/gyfelton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/493722?s=80&v=4"},"commit":{"message":"Remove allocation of extra swift module","shortMessageHtmlLink":"Remove allocation of extra swift module"}},{"before":null,"after":"a6bbd4725c0f865a1c0e94ff038060a50420de9f","ref":"refs/heads/thiago/rules_swift_package_manager-1","pushedAt":"2024-09-13T17:11:46.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"thiagohmcruz","name":"Thiago Cruz","path":"/thiagohmcruz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10197663?s=80&v=4"},"commit":{"message":"Collect swiftpkg vfs","shortMessageHtmlLink":"Collect swiftpkg vfs"}},{"before":null,"after":"02a507f74623a27c8f626b90c614de7633b69c2c","ref":"refs/heads/thiago/plugins-attr-apple_framework_packaging","pushedAt":"2024-09-11T15:48:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"thiagohmcruz","name":"Thiago Cruz","path":"/thiagohmcruz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10197663?s=80&v=4"},"commit":{"message":"Add plugins attribute to apple_framework_packaging","shortMessageHtmlLink":"Add plugins attribute to apple_framework_packaging"}},{"before":null,"after":"586be2f9c13b28c44650f001fe066800f1e1f5a3","ref":"refs/heads/cshi/vfsoverlay-fix","pushedAt":"2024-09-09T18:04:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"congt","name":"Cong Shi","path":"/congt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12762242?s=80&v=4"},"commit":{"message":"Ensures the determinism of vfsoverlay file (#912)\n\nhdrs, private_hdrs and swiftmodules of the same framework may be in\r\ndifferent order when building with different build settings in Bazel 7.\r\nThis change will ensure that the vfsoverlay file will be always the same\r\nfor the same dependency graph.","shortMessageHtmlLink":"Ensures the determinism of vfsoverlay file (#912)"}},{"before":"fd030f31d13f785d5037b80ca0e117fd8bb641a3","after":null,"ref":"refs/heads/cshi/hermetic-vsfoverlay","pushedAt":"2024-09-06T15:40:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"congt","name":"Cong Shi","path":"/congt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12762242?s=80&v=4"}},{"before":"9b3ba291752730025035131c3fde8d2069eaa267","after":"cf6010570f85d633b643027d43821b477737421c","ref":"refs/heads/master","pushedAt":"2024-09-06T15:40:54.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"congt","name":"Cong Shi","path":"/congt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12762242?s=80&v=4"},"commit":{"message":"Ensures the determinism of vfsoverlay file (#912)\n\nhdrs, private_hdrs and swiftmodules of the same framework may be in\r\ndifferent order when building with different build settings in Bazel 7.\r\nThis change will ensure that the vfsoverlay file will be always the same\r\nfor the same dependency graph.","shortMessageHtmlLink":"Ensures the determinism of vfsoverlay file (#912)"}},{"before":null,"after":"fd030f31d13f785d5037b80ca0e117fd8bb641a3","ref":"refs/heads/cshi/hermetic-vsfoverlay","pushedAt":"2024-09-06T07:25:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"congt","name":"Cong Shi","path":"/congt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12762242?s=80&v=4"},"commit":{"message":"Ensures the determinism of vfsoverlay file\n\nhdrs, private_hdrs and swiftmodules of the same framework may be in different order when building with different build settings in Bazel 7. This change will ensure that the vfsoverlay file will be always the same for the same dependency graph.","shortMessageHtmlLink":"Ensures the determinism of vfsoverlay file"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOVQwMDozODoyMC4wMDAwMDBazwAAAAS6SBl2","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOVQwMDozODoyMC4wMDAwMDBazwAAAAS6SBl2","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wNlQwNzoyNTo1OC4wMDAwMDBazwAAAASuoxio"}},"title":"Activity · bazel-ios/rules_ios"}