Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to xcconfig evaluation - analysis phase #594

Open
jerrymarino opened this issue Nov 7, 2022 · 1 comment
Open

Improvements to xcconfig evaluation - analysis phase #594

jerrymarino opened this issue Nov 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jerrymarino
Copy link
Contributor

Today there are a couple issues:

  • values are hardwired into rules_ios for a given version - makes bumping hard / a sticking point
  • a lot of config evaluation is done in loading phase: a few constraints implicate this. It makes it difficult to fully handle xcconfigs.

This one just highlights a couple problems with the existing design. Ideally we consider refactoring this into the analysis phase
@luispadron
Copy link
Collaborator

Related PRs for reference:

@luispadron luispadron added the enhancement New feature or request label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jerrymarino @luispadron