Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude files/folders that are .gitignore'd #1166

Open
alexeagle opened this issue Jan 28, 2022 · 2 comments · May be fixed by #1908
Open

Exclude files/folders that are .gitignore'd #1166

alexeagle opened this issue Jan 28, 2022 · 2 comments · May be fixed by #1908

Comments

@alexeagle
Copy link
Contributor

This is a major usability hurdle at one of Aspect's clients. Gazelle fails because they have some junk in their repo which is covered by a .gitignore so they don't realize they have an unclean state. The error messages when gazelle descends into these files is cryptic to them. They then ask a support question where it's not obvious that git clean -ffdx is the solution.

Gazelle should simply ignore things that are .gitignore'd (probably with a directive to opt-in/out)
@f0rmiga
Copy link
Contributor

f0rmiga commented Jan 28, 2022

I think Gazelle has enough users that Hyrum's law would be applied here. I wonder how many users have git-ignored files that end up in the targets that depend on a flow like:

go generate -> some git-ignored files -> gazelle -> bazel build

I believe it would be wise to make it opt-in rather than opt-out.

@garymm
Copy link

garymm commented Aug 30, 2022

Facing a similar issue with git submodules. Would be happy to opt in.

This was referenced Sep 4, 2024
Open
Open
jbedard added a commit to jbedard/bazel-gazelle that referenced this issue Sep 16, 2024
@jbedard
feat: add support for .gitignore
0f82486 
Close bazelbuild#1166
jbedard added a commit to jbedard/bazel-gazelle that referenced this issue Sep 16, 2024
@jbedard
feat: add support for .gitignore
fa4c3d6 
Close bazelbuild#1166
jbedard added a commit to jbedard/bazel-gazelle that referenced this issue Sep 21, 2024
@jbedard
feat: add support for .gitignore
1256149 
Close bazelbuild#1166
jbedard added a commit to jbedard/bazel-gazelle that referenced this issue Sep 21, 2024
@jbedard
feat: add support for .gitignore
cce54f9 
Close bazelbuild#1166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for .gitignore jbedard/bazel-gazelle
3 participants
@alexeagle @garymm @f0rmiga