Resolve issue with directory symlinks in local replace. #1829 #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Jun 20, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| linkInfo, err := os.Lstat(linkTarget) |
There was a problem hiding this comment.
Instead of EvalSymlinks and Lstat, could we just use Stat?
| } | ||
| if linkInfo.IsDir() { | ||
| // Rather than copying the directory symlink we create the dir and continue | ||
| // This resolves an issue where the walk attempts to copy files into the symlinked directory |
There was a problem hiding this comment.
Is the precise problem that the walk saw the symlink as not a directory (since the FileInfo comes from an Lstat) and this tried to copy over a file to what should be a directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
cmd/fetch_repo
What does this PR do? Why is it needed?
Handles directory symlinks in fetch_repo.
Which issues(s) does this PR fix?
Fixes #1829
Other notes for review