Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a RepositoryOverridesExperimentLoader #6651

Open
hisener opened this issue Aug 20, 2024 · 6 comments
Open

Introduce a RepositoryOverridesExperimentLoader #6651

hisener opened this issue Aug 20, 2024 · 6 comments
Assignees
Labels
awaiting-maintainer Awaiting review from Bazel team on issues P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin product: PyCharm PyCharm plugin type: feature request

Comments

@hisener
Copy link

hisener commented Aug 20, 2024

Description of the feature request:

I was wondering whether it makes sense to read the .intellij-experiments file from the project directory. That way, we don't need to ask developers to turn certain experiments on/off. For example, optimize_building_jars needs to be disabled in a repo where Bazel 5 is used. See also #5515 (comment).

The implementation would be similar to

/** Reads experiments override values from the user home directory. */
final class UserOverridesExperimentLoader extends FileExperimentLoader {
private static final String USER_EXPERIMENT_OVERRIDES_FILE =
SystemProperties.getUserHome() + File.separator + ".intellij-experiments";

Which category does this issue belong to?

Intellij, GoLand, CLion, PyCharm

What underlying problem are you trying to solve with this feature?

When an experiment doesn't work in a repository, all developers working in the repo need to add/update their ~/.intellij-experiments file.

What operating system, Intellij IDE and programming languages are you using? Please provide specific versions.

N/A

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@hisener hisener added awaiting-maintainer Awaiting review from Bazel team on issues type: feature request labels Aug 20, 2024
@github-actions github-actions bot added product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin product: PyCharm PyCharm plugin labels Aug 20, 2024
@tpasternak
Copy link
Collaborator

tpasternak commented Aug 21, 2024

Currently I'm assigning p4, but in case more users would like that, we will consider raising the priority.

@tpasternak tpasternak added the P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) label Aug 21, 2024
@tpasternak
Copy link
Collaborator

Btw there's yet another way to disable experiments - you can do it by setting vm options like here

"jvm_flags": ["-Dblaze.experiment.query.sync.new.artifact.management=1"],

@hisener
Copy link
Author

hisener commented Aug 21, 2024

🤔 Is there a way to set IntelliJ IDEA VM options per repo?

@tpasternak
Copy link
Collaborator

probably not

@tpasternak tpasternak added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) labels Aug 21, 2024
@tpasternak
Copy link
Collaborator

wait, but I'm not sure if it's that easy, experiments also affect the import process

@tpasternak tpasternak added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Aug 21, 2024
@tpasternak
Copy link
Collaborator

We didn't have such requests in the past. Experiments are not in general considered as "project stettings". This like that should be manipulated via the project view files. Adding this would end up in providing yet another config file apart from what we have. So I'm rather skeptical about this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin product: PyCharm PyCharm plugin type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants