Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run .. with Coverage report not shown while testing Java Project #6764

Closed
satyanandak opened this issue Sep 17, 2024 · 7 comments
Closed

Run .. with Coverage report not shown while testing Java Project #6764

satyanandak opened this issue Sep 17, 2024 · 7 comments
Assignees
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin Release Blocker issue is blocking the plugin release type: bug

Comments

@satyanandak
Copy link
Contributor

Description of the bug:

While Testing Java Project coverage report is not shown while testing Run .. with Coverage …however testing is getting passed.

Which category does this issue belong to?

Intellij

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

1> Import the Bazel project for Java
2> Click “Run .. with Coverage …” and make sure that a coverage report is shown to the left of the screen as follows:

Which Intellij IDE are you using? Please provide the specific version.

2024.1.6 & 2024.2

What programming languages and tools are you using? Please provide specific versions.

Java

What Bazel plugin version are you using?

2024.09.10.0.1-api-version-241 & 2024.09.10.0.1-api-version-242

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

image

@satyanandak satyanandak added type: bug awaiting-maintainer Awaiting review from Bazel team on issues labels Sep 17, 2024
@github-actions github-actions bot added the product: IntelliJ IntelliJ plugin label Sep 17, 2024
@mai93
Copy link
Collaborator

mai93 commented Sep 17, 2024

I think the culprit is 9b26850, I confirmed that the coverage result is shown for a plugin built right before that one. @tpasternak @mtoader can you advice on this release blocker?

@mai93 mai93 added the Release Blocker issue is blocking the plugin release label Sep 17, 2024
@mtoader
Copy link
Contributor

mtoader commented Sep 17, 2024

That PR shouldn't affect coverage display but one never knows. Let me take a look.

@mai93
Copy link
Collaborator

mai93 commented Sep 17, 2024

it does touch base/src/com/google/idea/blaze/base/run/coverage/CoverageUtils.java so maybe it has something to do with that

@mtoader
Copy link
Contributor

mtoader commented Sep 17, 2024

it does touch base/src/com/google/idea/blaze/base/run/coverage/CoverageUtils.java so maybe it has something to do with that

That change should be a no-op, but I might have missed something. Let me investigate

@mtoader
Copy link
Contributor

mtoader commented Sep 17, 2024

it does touch base/src/com/google/idea/blaze/base/run/coverage/CoverageUtils.java so maybe it has something to do with that

That change should be a no-op, but I might have missed something. Let me investigate

Oh, I know what it is. Will put a fix soon, once I validate (will take a while since I had to redo my local dev to support hirschen better). But if you can validate the following quicker it should be fine.

the change should be File coverageRoot = new File(blazeInfo.getOutputPath(), "_coverage"); not File coverageRoot = new File(blazeInfo.getOutputBase(), "_coverage");

@mtoader
Copy link
Contributor

mtoader commented Sep 17, 2024

@mai93 posted a fix PR.

mtoader added a commit to mtoader/intellij that referenced this issue Sep 17, 2024
mtoader added a commit to mtoader/intellij that referenced this issue Sep 17, 2024
mai93 pushed a commit that referenced this issue Sep 17, 2024
@mai93
Copy link
Collaborator

mai93 commented Sep 18, 2024

Thanks @mtoader! The fix is released in 2024.09.10.0.2, @satyanandak you can continue the manual test with it.

@mai93 mai93 closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin Release Blocker issue is blocking the plugin release type: bug
Projects
None yet
Development

No branches or pull requests

4 participants