Skip to content

Commit cb05580

Browse files
LilyL0uLilyL0u
authored
Merge pull request #12468 from bbc/WORLDSERVICE-366-reverb-rollout-enable-reverb-on-live-batch-2
Worldservice 366 reverb rollout enable reverb on live batch 2
2 parents 86562b7 + 563f5e0 commit cb05580

File tree

15 files changed

+78
-8
lines changed

15 files changed

+78
-8
lines changed

‎.yarn/cache/@babel-runtime-npm-7.26.9-8369ff039f-08edd07d77.zip ‎.yarn/cache/@babel-runtime-npm-7.26.10-d01a90d446-9d7ff8e96a.zip

128 KB
Binary file not shown.

‎cypress/e2e/specialFeatures/atiAnalytics/index.cy.js

+61
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ const canonicalTestSuites = [
117117
pageIdentifier: 'hindi.articles.c9w59wnx27ro.page',
118118
applicationType: 'responsive',
119119
contentType: 'article',
120+
useReverb: true,
120121
tests: [
121122
assertPageView,
122123
assertTopStoriesComponentView,
@@ -246,6 +247,7 @@ const canonicalTestSuites = [
246247
pageIdentifier: 'marathi.topics.c1wmk63rjkvt.page',
247248
applicationType: 'responsive',
248249
contentType: 'index-category',
250+
useReverb: true,
249251
componentTrackingContentType: 'topic-page',
250252
tests: [assertPageView],
251253
},
@@ -284,6 +286,65 @@ const canonicalTestSuites = [
284286
assertBillboardComponentClick,
285287
],
286288
},
289+
{
290+
path: '/persian/topics/crezq2dg9zwt',
291+
runforEnv: ['local', 'test'],
292+
service: 'persian',
293+
pageIdentifier: 'persian.topics.crezq2dg9zwt.page',
294+
applicationType: 'responsive',
295+
contentType: 'index-category',
296+
componentTrackingContentType: 'topic-page',
297+
useReverb: true,
298+
tests: [
299+
assertPageView,
300+
assertScrollableNavigationComponentView,
301+
assertScrollableNavigationComponentClick,
302+
assertDropdownNavigationComponentView,
303+
assertDropdownNavigationComponentClick,
304+
],
305+
},
306+
{
307+
path: '/indonesia',
308+
runforEnv: ['local', 'live'],
309+
service: 'indonesia',
310+
pageIdentifier: 'indonesia.page',
311+
applicationType: 'responsive',
312+
contentType: 'index-home',
313+
useReverb: true,
314+
tests: [
315+
assertPageView,
316+
assertScrollableNavigationComponentView,
317+
assertScrollableNavigationComponentClick,
318+
assertDropdownNavigationComponentView,
319+
assertDropdownNavigationComponentClick,
320+
],
321+
},
322+
{
323+
path: '/portuguese/podcasts/p07r3r3t',
324+
runforEnv: ['local', 'test', 'live'],
325+
service: 'portuguese',
326+
pageIdentifier: 'portuguese.bbc_brasil.podcasts.programmes.p07r3r3t.page',
327+
applicationType: 'responsive',
328+
contentType: 'player-episode',
329+
useReverb: true,
330+
tests: [
331+
assertPageView,
332+
assertPodcastLinksComponentView,
333+
assertPodcastLinksComponentClick,
334+
assertRecentAudioEpisodesComponentView,
335+
assertRecentAudioEpisodesComponentClick,
336+
],
337+
},
338+
{
339+
path: '/tamil/bbc_tamil_tv/tv_programmes/w13xttmy',
340+
runforEnv: ['local', 'test', 'live'],
341+
service: 'tamil',
342+
pageIdentifier: 'tamil.bbc_tamil_tv.tv_programmes.w13xttmy.page',
343+
applicationType: 'responsive',
344+
contentType: 'player-episode',
345+
useReverb: true,
346+
tests: [assertPageView],
347+
},
287348
// Article
288349
{
289350
path: '/pidgin/articles/cyv3zm4y428o',

‎package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"./cypress/**/*.*"
1010
],
1111
"resolutions": {
12-
"@babel/runtime": "7.26.9",
1312
"@optimizely/js-sdk-utils": "0.4.0",
1413
"uuid": "3.4.0",
1514
"[email protected]": "patch:winston@npm:3.8.2#.yarn/patches/winston-npm-3.8.2-2035e9cac4.patch",
@@ -144,7 +143,7 @@
144143
"@babel/preset-env": "7.26.9",
145144
"@babel/preset-react": "7.26.3",
146145
"@babel/preset-typescript": "7.26.0",
147-
"@babel/runtime": "7.26.9",
146+
"@babel/runtime": "7.26.10",
148147
"@cypress/webpack-preprocessor": "6.0.2",
149148
"@emotion/babel-plugin": "11.13.5",
150149
"@emotion/babel-preset-css-prop": "11.12.0",

‎src/app/components/ATIAnalytics/index.test.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,7 @@ describe('ATI Analytics Container', () => {
11121112
isAmp: false,
11131113
pageData: articleDataNews,
11141114
pageType: ARTICLE_PAGE,
1115-
service: 'mundo',
1115+
service: 'hausa', // this is a temporary fix for this unit test failing as this service will have reverb enabled in the last batch
11161116
isUK: true,
11171117
});
11181118

‎src/app/lib/config/services/hindi.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
1313
atiAnalyticsAppName: 'news-hindi',
1414
atiAnalyticsProducerId: '52',
1515
atiAnalyticsProducerName: 'HINDI',
16+
useReverb: true,
1617
chartbeatDomain: 'hindi.bbc.co.uk',
1718
brandName: 'BBC News हिंदी',
1819
product: 'BBC News',

‎src/app/lib/config/services/indonesia.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
1313
atiAnalyticsAppName: 'news-indonesia',
1414
atiAnalyticsProducerId: '54',
1515
atiAnalyticsProducerName: 'INDONESIAN',
16+
useReverb: true,
1617
chartbeatDomain: 'indonesian.bbc.co.uk', // this is meant to be different to the service name
1718
brandName: 'BBC News Indonesia',
1819
product: 'BBC News',

‎src/app/lib/config/services/marathi.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
1313
atiAnalyticsAppName: 'news-marathi',
1414
atiAnalyticsProducerId: '59',
1515
atiAnalyticsProducerName: 'MARATHI',
16+
useReverb: true,
1617
chartbeatDomain: 'marathi.bbc.co.uk',
1718
brandName: 'BBC News मराठी',
1819
product: 'BBC News',

‎src/app/lib/config/services/mundo.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
1313
atiAnalyticsAppName: 'news-mundo',
1414
atiAnalyticsProducerId: '62',
1515
atiAnalyticsProducerName: 'MUNDO',
16+
useReverb: true,
1617
chartbeatDomain: 'mundo.bbc.co.uk',
1718
brandName: 'BBC News Mundo',
1819
product: 'BBC News',

‎src/app/lib/config/services/persian.ts

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export const service: DefaultServiceConfig = {
1515
atiAnalyticsAppName: 'news-persian',
1616
atiAnalyticsProducerId: '69',
1717
atiAnalyticsProducerName: 'PERSIAN',
18+
useReverb: true,
1819
chartbeatDomain: 'persian.bbc.co.uk',
1920
brandName: 'BBC News فارسی',
2021
serviceLocalizedName: 'فارسی',

‎src/app/lib/config/services/portuguese.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
1313
atiAnalyticsAppName: 'news-portuguese',
1414
atiAnalyticsProducerId: '33',
1515
atiAnalyticsProducerName: 'BRASIL',
16+
useReverb: true,
1617
chartbeatDomain: 'brasil.bbc.co.uk', // this is meant to be different to the service name
1718
brandName: 'BBC News Brasil',
1819
product: 'BBC News',

‎src/app/lib/config/services/punjabi.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
1313
atiAnalyticsAppName: 'news-punjabi',
1414
atiAnalyticsProducerId: '73',
1515
atiAnalyticsProducerName: 'PUNJABI',
16+
useReverb: true,
1617
chartbeatDomain: 'punjabi.bbc.co.uk',
1718
brandName: 'BBC News ਪੰਜਾਬੀ',
1819
product: 'BBC News',

‎src/app/lib/config/services/russian.ts

+1
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ export const service: DefaultServiceConfig = {
320320
atiAnalyticsAppName: 'news-russian',
321321
atiAnalyticsProducerId: '75',
322322
atiAnalyticsProducerName: 'RUSSIAN',
323+
useReverb: true,
323324
chartbeatDomain: 'russian.bbc.co.uk',
324325
brandName: 'BBC News Русская служба',
325326
product: 'BBC News',

‎src/app/lib/config/services/tamil.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
1313
atiAnalyticsAppName: 'news-tamil',
1414
atiAnalyticsProducerId: '87',
1515
atiAnalyticsProducerName: 'TAMIL',
16+
useReverb: true,
1617
chartbeatDomain: 'tamil.bbc.co.uk',
1718
brandName: 'BBC News தமிழ்',
1819
product: 'BBC News',

‎src/app/lib/config/services/telugu.ts

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const service: DefaultServiceConfig = {
1313
atiAnalyticsAppName: 'news-telugu',
1414
atiAnalyticsProducerId: '89',
1515
atiAnalyticsProducerName: 'TELUGU',
16+
useReverb: true,
1617
chartbeatDomain: 'telugu.bbc.co.uk',
1718
brandName: 'BBC News తెలుగు',
1819
product: 'BBC News',

‎yarn.lock

+5-5
Original file line numberDiff line numberDiff line change
@@ -1709,12 +1709,12 @@ __metadata:
17091709
languageName: node
17101710
linkType: hard
17111711

1712-
"@babel/runtime@npm:7.26.9":
1713-
version: 7.26.9
1714-
resolution: "@babel/runtime@npm:7.26.9"
1712+
"@babel/runtime@npm:7.26.10, @babel/runtime@npm:^7.1.2, @babel/runtime@npm:^7.12.13, @babel/runtime@npm:^7.12.18, @babel/runtime@npm:^7.12.5, @babel/runtime@npm:^7.18.3, @babel/runtime@npm:^7.8.4":
1713+
version: 7.26.10
1714+
resolution: "@babel/runtime@npm:7.26.10"
17151715
dependencies:
17161716
regenerator-runtime: "npm:^0.14.0"
1717-
checksum: 10/08edd07d774eafbf157fdc8450ed6ddd22416fdd8e2a53e4a00349daba1b502c03ab7f7ad3ad3a7c46b9a24d99b5697591d0f852ee2f84642082ef7dda90b83d
1717+
checksum: 10/9d7ff8e96abe3791047c1138789c742411e3ef19c4d7ca18ce916f83cec92c06ec5dc64401759f6dd1e377cf8a01bbd2c62e033eb7550f435cf6579768d0d4a5
17181718
languageName: node
17191719
linkType: hard
17201720

@@ -14755,7 +14755,7 @@ __metadata:
1475514755
"@babel/preset-env": "npm:7.26.9"
1475614756
"@babel/preset-react": "npm:7.26.3"
1475714757
"@babel/preset-typescript": "npm:7.26.0"
14758-
"@babel/runtime": "npm:7.26.9"
14758+
"@babel/runtime": "npm:7.26.10"
1475914759
"@bbc/web-vitals": "npm:2.5.3"
1476014760
"@cypress/webpack-preprocessor": "npm:6.0.2"
1476114761
"@emotion/babel-plugin": "npm:11.13.5"

0 commit comments

Comments
 (0)