Add support for margin to fitView function

[alexgrozav]

When having buttons on top of the screen, the fitView function can produce results that get overlapped by the buttons.

Here's what my workflow looks like after fitView (with 0.2 padding) in this scenario:

My proposal is to have another property added to the function such as margin or safeArea or bleed with pixel sizes to handle this kind of scenario:

await fitView({ 
  maxZoom: 2, 
  padding: 0.2, 
  margin: { top: 16, right: 48, bottom: 48,  left: 0 } 
});

[bcakmakoglu]

What I could offer instead of margin is making padding more expressive like it is in RF.
For example fitView({ padding: { top: 10, bottom: 30, left: 0, right: 40 } }) or fitView({ padding: { x: 10, y: 20 } })
How does that sound? Would that help with your use-case?

[alexgrozav]

Sounds like an improvement to me! I checked how the padding influences the fitView function in the current implementation and I couldn't figure out how to set a calculated pixel-inferred value to it.

[bcakmakoglu]

Will be in the next minor release, probably today or tomorrow :)

[bcakmakoglu]

The new padding would allow you to specify it with a unit like 10px or 10% (just a number is basically the same as using %).

Edit: Just a number is not like using % - it's just the legacy calculation which... don't ask me how it works 🥲

[bcakmakoglu]

Released with 1.47.0 - let me know if that helps with your use-case @alexgrozav

[alexgrozav]

Thank you! I'll keep you posted