Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new share structure for imported companies throwing an error. #26686

Open
riyazuddinsyed opened this issue Mar 21, 2025 · 5 comments
Open
Labels
bug Something isn't working Data Migration Entities Data Migration - DO NOT USE FOR ANYTHING ELSE Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority3

Comments

@riyazuddinsyed
Copy link
Collaborator

Describe the bug in the current situation
When a new Share Structure is added for an imported company that has a share structure with "No Maximum" shares, then the UI throws an error saying "Must provide a value for Maximum No Of Shares."

Steps to reproduce the behavior:

  1. Go to 'http://test.bcregistry.ca/business/auth/'
  2. Log in as staff.
  3. Search for BC1321111
  4. Start an Alteration.
  5. Add a new share structure
  6. Hit on File and pay..
  7. See an error

Screenshots/ Visual Reference/ Source
Screen Shot 2025-03-21 at 12.49.50 PM.png

@riyazuddinsyed riyazuddinsyed added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Mar 21, 2025
@argush3
Copy link
Collaborator

argush3 commented Mar 24, 2025

There are known share data issues where the COLIN corps do not have data for required fields in the modernized system. Will review to see if this is the case.

@argush3 argush3 added the Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. label Mar 24, 2025
@argush3
Copy link
Collaborator

argush3 commented Mar 24, 2025

@chenhongjing
Copy link
Collaborator

@argush3 We have had a conversation with this before. For this specific issue, COLIN corps have a tons of inconsistent or even invalid data in the fields that we map to max_share_flag and max_shares in modernized system.

@vikas-gov vikas-gov added the Data Migration Entities Data Migration - DO NOT USE FOR ANYTHING ELSE label Mar 24, 2025
@argush3
Copy link
Collaborator

argush3 commented Mar 24, 2025

@argush3 We have had a conversation with this before. For this specific issue, COLIN corps have a tons of inconsistent or even invalid data in the fields that we map to max_share_flag and max_shares in modernized system.

yes, we still have to verify this for the corp mentioned in this ticket. If it's verified, there needs to be a decision made as to what we do for early adopters that have this issue.

@argush3
Copy link
Collaborator

argush3 commented Mar 24, 2025

Hongjing has confirmed this is the issue she mentioned above.

A decision has been made by Olga that we do not need to deal with this for early adopters release for the moment so don't need to work on this right now.

@chenhongjing chenhongjing removed their assignment Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Data Migration Entities Data Migration - DO NOT USE FOR ANYTHING ELSE Entities - Lorrie A label to filter on the tickets for the Entities based team that David is PO for. Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority3
Projects
None yet
Development

No branches or pull requests

4 participants