Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting an error when trying to build a radar from scratch #8

Open
bpamiri opened this issue Jan 26, 2015 · 7 comments
Open

Getting an error when trying to build a radar from scratch #8

bpamiri opened this issue Jan 26, 2015 · 7 comments

Comments

@bpamiri
Copy link

bpamiri commented Jan 26, 2015

I'm trying to build a radar and I thought I'd start with the data file that is included and remove all the individual elements to get a blank radar. This step works, I was able to produce a blank radar. But then with I try to add my first element I get an error. Is there anything else one needs to do other than changing the radarData.js file to get a new radar to work.

@sfudeus
Copy link

sfudeus commented Jan 28, 2015

I have a similar issue: When I add data for the top right or bottom left quadrant with a radius of >=100, the JS fails. Maybe this is identical, I suggest to try to stick with lower radius for testing it.
For top left and bottom right, larger radius is working fine ...

@NetAppBlueDevil
Copy link

Looks like you need one item of < 100 radius in a quadrant or else the radar does not display

@NetAppBlueDevil
Copy link

Looks like this is a bug in the underscore.js library that is causing the error if you have a quadrant with no items in it. Replacing the 1.5.2 version of the lib included in this project with the latest 1.8.2 version available seems to resolve the problem.

@jdelaire
Copy link

jdelaire commented Apr 8, 2015

I have the same kind of issue, if I go above 200 in radius the graph won't render and w got the following javascript error:
TypeError: data is undefined inside protovis-d3.2.js
ps: I have upgraded to underscore 1.8.3 too

@sxt
Copy link

sxt commented Oct 27, 2015

I narrowed this down a bit - if you have an empty segment and there is a non-empty outer segment in the same quadrant, you will get the above javascript error.

@sxt sxt mentioned this issue Jan 8, 2016
fffej added a commit to fffej/techradar that referenced this issue Jul 11, 2016
Each segment of a quadrant should have an item (e.g. if something is in segments 1, 2 and 4 then there is an error because 3 is `undefined`).
@fffej
Copy link
Contributor

fffej commented Jul 11, 2016

I've opened up a pull request with a fix for this. In radar.js, _.groupBy doesn't take into account groups that exist. I've hacked in a fill in the blanks style fix.

@ohookins
Copy link

I can confirm that the fix from @fffej works for me. Would be great to merge it!

bdargan added a commit that referenced this issue Mar 2, 2017
hanokhaloni pushed a commit to hanokhaloni/techradar that referenced this issue Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants