clutter config option not working

[mfiano]

I added this to my config.yaml:

clutter: [ "Thumbs.DB", ".DS_Store", ".jpg", ".png" ]

...and noticed still, import was leaving behind directories with just coverart left in them. As suggested I changed it to not use wildcards to narrow down the issue:

clutter: [ "Thumbs.DB", ".DS_Store", "cover.jpg", "cover.png" ]

...and still, it is leaving directories behind with just "cover.(jpg|png) behind in them.

[sampsyo]

I can't reproduce this on my end—the above clutter setting correctly cleans up directories with "cover.jpg" in them on my machine.

Are there any other hidden files that could be preventing directory pruning?

[mfiano]

No hidden files. 1 directory named "00 - Alice Cooper - The Definitive" and inside just a "cover.jpg" file. I tried running beets from within the directory as well as up a dir to be outside of it. Both leave the directory and the file in place.

beets version 1.1.0-beta.3 / beets-hg 1836-1

[sampsyo]

Very weird; I don't know why I can't reproduce this. Can you paste your whole config so I can try that out?

On Sun, Mar 24, 2013 at 11:10 PM, Michael Fiano [email protected]
wrote:

No hidden files. 1 directory named "00 - Alice Cooper - The Definitive" and inside just a "cover.jpg" file. I tried running beets from within the directory as well as up a dir to be outside of it. Both leave the directory and the file in place.

Reply to this email directly or view it on GitHub:
#233 (comment)

[mfiano]

http://codepad.org/k5in6NV5

[sampsyo]

So strange. I gave this a try with exactly this config and the directory was cleaned up as expected.

Any chance you're running into #130? That is, are you beet importing the album directory or its parent?

[mfiano]

As mentioned in my 2nd post, I tried both.

[mfiano]

On closer inspection, some directories are left behind empty, when running 'beet import' in a parent dir with multiple album directories, so this seems like a general file/dir deletion problem rather than clutter.

[sampsyo]

Aha. Thanks for looking closer. Is there something in common among the directories that aren't cleaned up or does it seem to be random?

[mfiano]

I could be mistaken, but it seems as though directories that don't have any music in them (just empty or clutter files) are not accounted for...i just did a small beet import and purposely gave it 1 empty album dir, and 1 dir with just a cover.jpg file....both were left behind undeleted, but the ones with music (even those with image files) were deleted successfully.

[sampsyo]

That would be it! Beets only prunes directories containing music that it imports. Empty directories (or ones without music files) never even go through the import pipeline so they're never pruned.

We could address this to do more effective cleaning, but I'm not sure what a straightforward solution would look like. If there's a design to be proposed here, let's open another ticket.

On Mar 25, 2013, at 4:22 PM, Michael Fiano [email protected] wrote:

I could be mistaken, but it seems as though directories that don't have any music in them (just empty or clutter files) are not accounted for...i just did a small beet import and purposely gave it 1 empty album dir, and 1 dir with just a cover.jpg file....both were left behind undeleted, but the ones with music (even those with image files) were deleted successfully.

—
Reply to this email directly or view it on GitHub.