Type of fixture does not work

[ygorpontelo]

I have installed the language server in Zed and it's working great for fixture discovery, but the type of the fixture is not being set.

For example:

It correctly shows the fixture and the return type

But the variable itself is still with unknown type:

Is there a way to set this value? Maybe it would have to interact with the other language server? Zed uses basedpyright by default i think.

[bellini666]

This is a little bit tricky, as who is actually showing the type of the attribute is your other language server (pyright, ty, pyrefly, etc), and we have no way to "inject" it there

Options that I think can help here:

1. We can provide an inlay hint in those cases, which will be nice visually, but won't allow you to take all the benefits from it (e.g. wait.| getting completions for it)
2. We can also add a codeaction, that when the argument is untyped, but we do have a type annotation in the fixture, the code action would fix it by typing it for you

Wdyt?

[ygorpontelo]

First one would be nice but i feel the second is more useful. If you can do both it would be awesome.

[benediktziegler]

There is already some support for inlayHints, but it is a bit flaky/buggy (with multiline signatures).
It also shows hints for

@pytest.mark.usefixtures("somefixture: ItsType")

which I would assume isn't anything we do want to have?

[bellini666]

@benediktziegler makes sense

What do you think we should do here?

[benediktziegler]

I think the approach in #108 should work. We return hints for the whole file (flakiness) and not for string literals (usefixtures).

BTW, in zed, the inlayHints needed to be enabled in the settings (https://zed.dev/docs/reference/all-settings?highlight=inlay%20hints#inlay-hints).
VS Code has it on by default(?)

[benediktziegler]

Regarding the code action, we can add code actions to add the type annotation to a fixture under the cursor (source.pytest-ls maybe?) and for all fixtures in the current file (source.fixAll.pytest-ls maybe?) plus the required imports.

Screencast.from.2026-03-24.08-42-01.webm