directory checks should exclude infra in repositories other than exemplar

[ednolan]

In two places, directory.py has the following code:

        if self.repo_name == "exemplar":
            exclude_dirs.extend(["cookiecutter", "infra"])

This leads to spurious errors when running beman-tidy on a repository other than exemplar that uses infra/ as a beman-submodule:

Running check [Requirement][directory.papers] ...
[error          ][directory.papers         ]: Misplaced paper file found: /home/eddie/sync/cpp/bemanproject/any_view/infra/README.md
[error          ][directory.papers         ]: Misplaced paper file found: /home/eddie/sync/cpp/bemanproject/any_view/infra/tools/beman-submodule/README.md
[error          ][directory.papers         ]: Misplaced paper file found: /home/eddie/sync/cpp/bemanproject/any_view/infra/tools/beman-tidy/README.md

[wermos]

To be clear, are you suggesting that the cookiecutter and infra directories should be added to exclude_dirs unconditionally?

[ednolan]

No, I'm just suggesting that for infra. Other repositories won't have a cookiecutter subdirectory, but they will have infra.

[neatudarius]

@vickgoodman , can you implement this after winter shutdown?