Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support for poetry for installing dependencies in bento #4009

Closed
arkodoescode opened this issue Jul 2, 2023 · 8 comments
Closed

Comments

@arkodoescode
Copy link

Feature request

I would like it if bentofile python field could support a pyproject.toml value in requirements instead of a requirements.txt file with support for poetry.

Motivation

Poetry is used in production quite a lot and this seems like a natural choice.

Other

No response

@bojiang
Copy link
Member

bojiang commented Jul 3, 2023

Agree. It makes sense to support PEP 621.
And the good news is pip-tools (we are using it to lock the dependencies) already supports it. Thus it should be a natural change.
jazzband/pip-tools#1510

@bojiang
Copy link
Member

bojiang commented Jul 3, 2023

Would you like to help adding this feature?

@aarnphm
Copy link
Contributor

aarnphm commented Jul 31, 2023

I think adding poetry is nice, but it is just adding a churn for us to maintain.

Esp in the past, we haven't had good experiences with poetry. Not sure if this has changed with the recent release. Maybe we can add support for pdm since we have @frostming 😃

@arkodoescode
Copy link
Author

Would you like to help adding this feature?

@arkodoescode
Copy link
Author

Would you like to help adding this feature?

I would love to help if and when I have bandwidth.

@aarnphm
Copy link
Contributor

aarnphm commented Aug 14, 2023

I think a better discussion is to make bento pip-installable, rather than supporting specific backend for installation. Because at the end of the day, I think all packages can/should just be installed with pip within an isolated container.

@ianwesleyarmstrong
Copy link

Any updates on this? It would be great addition IMO

@aarnphm
Copy link
Contributor

aarnphm commented Oct 22, 2023

@frostming I think for Bento it can also generate a pyproject.toml. with this it will probably support whatever framework backend for PEP621

Would be a great feature for this is to make pip-installable bento, probably an adjacent feature

@aarnphm aarnphm closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants