Fix RC smoothing (#4637)

* Fix rc smoothing setpointhz range

* Rename

* Remove duplicate key

* Rename smoothingMode to smoothing

* Sonar nitpick

Author: haslinghuis

locales/en/messages.json

@@ -2107,9 +2107,6 @@
     "receiverRcSmoothingFeedforwardTypeAuto": {
         "message": "Auto"
     },
-    "receiverRcSmoothingMode": {
-        "message": "Smoothing Mode"
-    },
     "pidTuningDtermSetpointTransition": {
         "message": "D Setpoint transition"
     },

src/js/fc.js

@@ -632,7 +632,7 @@ const FC = {
             rcSmoothingDerivativeType: 0,
             rcSmoothingAutoFactor: 0,
             usbCdcHidType: 0,
-            rcSmoothingMode: 0,
+            rcSmoothing: 0,
             elrsUid: [0, 0, 0, 0, 0, 0],
         };
 

src/js/msp/MSPHelper.js

@@ -1053,7 +1053,7 @@ MspHelper.prototype.process_data = function (dataHandler) {
                     data.readU8(); // was FC.RX_CONFIG.rcSmoothingDerivativeType
                     FC.RX_CONFIG.usbCdcHidType = data.readU8();
                     FC.RX_CONFIG.rcSmoothingAutoFactor = data.readU8();
-                    FC.RX_CONFIG.rcSmoothingMode = data.readU8();
+                    FC.RX_CONFIG.rcSmoothing = data.readU8();
 
                     if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_45)) {
                         const elrsUidLength = 6;
@@ -2004,7 +2004,7 @@ MspHelper.prototype.crunch = function (code, modifierCode = undefined) {
             buffer.push8(FC.RX_CONFIG.usbCdcHidType).push8(FC.RX_CONFIG.rcSmoothingAutoFactor);
 
             // Introduced in 1.44
-            buffer.push8(FC.RX_CONFIG.rcSmoothingMode);
+            buffer.push8(FC.RX_CONFIG.rcSmoothing);
 
             // Introduced in 1.45
             if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_45)) {

src/js/tabs/receiver.js

@@ -620,10 +620,10 @@ receiver.initialize = function (callback) {
 
         const rc_smoothing_protocol_e = $('select[name="rcSmoothing-select"]');
         rc_smoothing_protocol_e.change(function () {
-            FC.RX_CONFIG.rcSmoothingMode = parseFloat($(this).val());
+            FC.RX_CONFIG.rcSmoothing = Number.parseInt($(this).val());
             updateInterpolationView();
         });
-        rc_smoothing_protocol_e.val(FC.RX_CONFIG.rcSmoothingMode);
+        rc_smoothing_protocol_e.val(FC.RX_CONFIG.rcSmoothing);
 
         const rcSmoothingNumberElement = $('input[name="rcSmoothingSetpointHz-number"]');
         rcSmoothingNumberElement.val(FC.RX_CONFIG.rcSmoothingSetpointCutoff);
@@ -967,7 +967,7 @@ function updateInterpolationView() {
     $(".tab-receiver .rcSmoothingOff").text(i18n.getMessage("off"));
     $(".tab-receiver .rcSmoothingOn").text(i18n.getMessage("on"));
 
-    if (FC.RX_CONFIG.rcSmoothingMode === 0) {
+    if (FC.RX_CONFIG.rcSmoothing === 0) {
         $(".tab-receiver .rcSmoothing-feedforward-cutoff").hide();
         $(".tab-receiver .rcSmoothing-setpoint-cutoff").hide();
         $(".tab-receiver .rcSmoothing-feedforward-manual").hide();

src/tabs/receiver.html

@@ -191,8 +191,8 @@
                             </td>
                             <td colspan="2">
                                 <div>
-                                    <label class="rcSmoothingMode">
-                                        <span i18n="receiverRcSmoothingMode"></span>
+                                    <label>
+                                        <span i18n="receiverRcSmoothing"></span>
                                     </label>
                                 </div>
                             </td>
@@ -216,7 +216,7 @@
                             </td>
                         </tr>
                         <tr class="rcSmoothing-setpoint-manual">
-                            <td class="rcSmoothing-setpoint-cutoff"><input type="number" name="rcSmoothingSetpointHz-number" step="1" min="1" max="255"/></td>
+                            <td class="rcSmoothing-setpoint-cutoff"><input type="number" name="rcSmoothingSetpointHz-number" step="1" min="0" max="255"/></td>
                             <td class="rcSmoothing-setpoint-cutoff" colspan="2">
                                 <div>
                                     <label>