fix error typo

Author: ctzsnooze

src/js/tabs/onboard_logging.js

@@ -477,38 +477,96 @@ onboard_logging.initialize = function (callback) {
     }
 
     function flash_save_begin() {
-        if (GUI.connected_to) {
-            self.blockSize = self.BLOCK_SIZE;
+        if (!GUI.connected_to) return;
 
-            flash_update_summary(function () {
-                const maxBytes = FC.DATAFLASH.usedSize;
+        self.blockSize = self.BLOCK_SIZE;
 
-                let openedFile;
-                prepare_file(function (fileWriter) {
-                    let nextAddress = 0;
-                    let totalBytesCompressed = 0;
+        // Refresh occupied size in case it changed while the tab was open
+        flash_update_summary(() => {
+            const maxBytes = FC.DATAFLASH.usedSize;
+
+            let openedFile;
+            let totalBytesCompressed = 0;
 
-                    show_saving_dialog();
+            show_saving_dialog();
 
-                    const MAX_SIMPLE_RETRIES = 5;
-                    const RETRY_BACKOFF_MS = 30;
-                    let simpleRetryCount = 0;
+            const MAX_SIMPLE_RETRIES = 5;
+            const RETRY_BACKOFF_MS = 30; // ms
+            const startTime = new Date().getTime();
 
-                    const startTime = new Date().getTime();
+            prepare_file((fileWriter) => {
+                FileSystem.openFile(fileWriter).then((file) => {
+                    openedFile = file;
+
+                    let nextAddress = 0;
 
-                    function onChunkRead(chunkAddress, chunkDataView, bytesCompressed) {
-                        // ... all recursive logic ...
+                    // Queue-based read function
+                    function readNextBlock() {
+                        if (saveCancelled || nextAddress >= maxBytes) {
+                            mark_saving_dialog_done(startTime, nextAddress, totalBytesCompressed);
+                            FileSystem.closeFile(openedFile);
+                            return;
+                        }
+
+                        let simpleRetryCount = 0;
+
+                        function attemptRead() {
+                            mspHelper.dataflashRead(
+                                nextAddress,
+                                self.blockSize,
+                                (chunkAddress, chunkDataView, bytesCompressed) => {
+                                    if (chunkDataView && chunkDataView.byteLength > 0) {
+                                        simpleRetryCount = 0;
+
+                                        const blob = new Blob([chunkDataView]);
+                                        FileSystem.writeChunk(openedFile, blob);
+
+                                        nextAddress += chunkDataView.byteLength;
+
+                                        if (typeof bytesCompressed === "number") {
+                                            if (totalBytesCompressed == null) totalBytesCompressed = 0;
+                                            totalBytesCompressed += bytesCompressed;
+                                        }
+
+                                        $(".dataflash-saving progress").attr("value", (nextAddress / maxBytes) * 100);
+
+                                        // Continue with next block
+                                        readNextBlock();
+                                    } else if (chunkDataView && chunkDataView.byteLength === 0) {
+                                        // Zero-length block → EOF
+                                        mark_saving_dialog_done(startTime, nextAddress, totalBytesCompressed);
+                                        FileSystem.closeFile(openedFile);
+                                    } else {
+                                        // Null/missing block
+                                        if (simpleRetryCount < MAX_SIMPLE_RETRIES) {
+                                            simpleRetryCount++;
+                                            if (simpleRetryCount % 2 === 1) {
+                                                console.warn(
+                                                    `Null/missing block at ${nextAddress}, retry ${simpleRetryCount}`,
+                                                );
+                                            }
+                                            setTimeout(attemptRead, RETRY_BACKOFF_MS);
+                                        } else {
+                                            console.error(
+                                                `Skipping null block at ${nextAddress} after ${MAX_SIMPLE_RETRIES} retries`,
+                                            );
+                                            nextAddress += self.blockSize;
+                                            readNextBlock();
+                                        }
+                                    }
+                                },
+                            );
+                        }
+
+                        attemptRead();
                     }
 
-                    // Fetch the initial block
-                    FileSystem.openFile(fileWriter).then((file) => {
-                        openedFile = file;
-                        mspHelper.dataflashRead(nextAddress, self.blockSize, onChunkRead);
-                    });
+                    // Start reading the first block
+                    readNextBlock();
                 });
             });
-        }
-    } // <-- this is the exact end of flash_save_begin
+        });
+    } // end of flash_save_begin
 
     function prepare_file(onComplete) {
         const prefix = "BLACKBOX_LOG";