Tweaked animations?

[elimisteve]

The incoming and outgoing default animation for https://fkhadra.github.io/react-toastify/ is so awesome. Would you consider tweaking the existing animation to support it? If not, would you accept a PR that swaps the current animation with the default react-toastify one?

Thanks!

[antony]

Yep - I love it :)

I didn't write the animations, somebody else added them in a PR. They're decent, but I do prefer the toastify ones, so I'll be happy to take a PR.

[tmadge]

This broke things for me.... now the notification slides in and immediately disappears. I think its opacity flips back to 0 for some reason.

[antony]

What broke things? There hasn't been any work done on this issue as far as I know.

[elimisteve]

@tmadge is probably referring to https://github.com/beyonk-adventures/svelte-notifications/pull/17/files

[antony]

It seems to work fine for me - https://svelte.dev/repl/dd506c546df84c1994a5ae9928ad23b1?version=3.12.1

Do you have any more detail? browser etc?

[elimisteve]

@tmadge If you can make the notifications zip off to the right (like https://fkhadra.github.io/react-toastify/ ) rather than fading away then that'd be great! @timsully and I haven't gotten around to doing that part yet, but I sure think it'd be an improvement.

[tmadge]

Thanks for the repl. It must be something in my site that's causing it to hide.

I added opacity: 1 to the to section of the animate-in keyframe, which seems to have fixed it.

to {
  opacity: 1;
  transform: none;
}

[phelbas]

I had to make the same opacity patch because out of the box had the same issue.