You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using the <br> or <br/> tag causes the parser to create mlang tags due to mismatching opening/closing tags:
https://github.com/bfh/moodle-tiny_multilang2/blob/main/amd/src/htmlparser.js#L134 after further investigation, it seems like all imbalanced tags should show this behavior. One can argue, if the prevention of imbalanced tags in the parser of the plugin is even neccessary or beneficial, if the backend implementation is not checking for those things. Either way, another fix could be to add special cases for imbalanced tags like <br>, <img>
Another sample ist just placing an img inside mlang {mlang de}<img src="...">{mlang}
More over using mlang across tags like: <p>{mlang de}</p><p></p><p>{mlang}</p>, results create of tags. The introduction of the html parser forces mlang tags to ONLY be filled by raw text and NO html tag at all
The text was updated successfully, but these errors were encountered:
Minimal sample:
{mlang de}<br>{mlang}
Using the
<br>
or<br/>
tag causes the parser to create mlang tags due to mismatching opening/closing tags:https://github.com/bfh/moodle-tiny_multilang2/blob/main/amd/src/htmlparser.js#L134 after further investigation, it seems like all imbalanced tags should show this behavior. One can argue, if the prevention of imbalanced tags in the parser of the plugin is even neccessary or beneficial, if the backend implementation is not checking for those things. Either way, another fix could be to add special cases for imbalanced tags like
<br>
,<img>
Another sample ist just placing an img inside mlang
{mlang de}<img src="...">{mlang}
More over using mlang across tags like:
<p>{mlang de}</p><p></p><p>{mlang}</p>
, results create of tags. The introduction of the html parser forces mlang tags to ONLY be filled by raw text and NO html tag at allThe text was updated successfully, but these errors were encountered: