Merge pull request #10 from carsonreinke/callback_url

Ignore query string for callback url

Author: mattolson

.gitignore

@@ -1,4 +1,4 @@
 .bundle
 Gemfile.lock
 coverage
-reports
+reports

lib/omniauth/strategies/bigcommerce.rb

@@ -48,6 +48,11 @@ def authorize_params
           end
         end
       end
+      
+      #Exclude query string in callback
+      def callback_url
+        full_host + script_name + callback_path
+      end
     end
   end
 end

spec/omniauth/strategies/bigcommerce_spec.rb

@@ -45,6 +45,17 @@
     it 'should have the correct path' do
       expect(subject.callback_path).to eq('/auth/bigcommerce/callback')
     end
+    
+    it 'should use no query string for callback url' do
+      request = double('Request', :params => {}, :cookies => {}, :env => {})
+      allow(request).to receive(:scheme).and_return('http')
+      allow(request).to receive(:url).and_return('http://example.com')
+
+      allow(subject).to receive(:request).and_return(request)
+      allow(subject).to receive(:script_name).and_return('')
+
+      subject.callback_url
+    end
   end
 
   context 'authorize options' do