You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This project is currently using sanitize.css which is not updated for 3 years.
overflow-wrap: break-word too offensive but it's ok.
Points against using sanitize.css:
Unnecessary declarations that opinionated and not needed:
background-repeat: no-repeat;, no need to set this, it should be using default behavior which is repeat to be more predictable.
text-decoration: inherit; text-decoration property used in those elements: a, s, u, del, ins, strike and there is no need to set the inheritance over ::before, ::after, same for vertical-align: inherit.
cursor: default in most elements cursor: default is a default value and another things like cursor: auto for input, textarea, so it's no need to set up, let the browser do its thing.
In abbr[title] there is 2 declarations indeed duplicated: underline then underline dotted as values, underline dotted used by Firefox as default (so it should be used as only declaration):
smallfont-size: 80% unneeded because it's font set it up 2 see: main.css = font-size: .8em;
margin: 0 to button, input, select elements: not needed because button, margin has no margin and input[type="*"] have some margins but not big numbers so something like Stack layout would be adorable and it wouldn't need us to set margin to 0. ( .stack>+{ margin-block-start: 1rem } )
-webkit-appearance: button should be avoided to use.
border: 1px solid #a0a0a0 set for fieldset to achieve "Change the inconsistent appearance in all browsers (opinionated)." but actually there is no inconsistency: see https://browserdefaultstyles.com/#fieldset default value is border: groove 2px ThreeDFace
In fact vendor specific things should be avoided...
:focus-visible isn't needed but :target is fine but no need for z-index: 2
summary declaration is ok but it's better to use just summary and not details > summary:first-of-type because website authors themselves shouldn't add more then one summary to details element and for not increasing specificity it's better to stick with summary.
This project is currently using sanitize.css which is not updated for 3 years.
overflow-wrap: break-word
too offensive but it's ok.Points against using sanitize.css:
Unnecessary declarations that opinionated and not needed:
background-repeat: no-repeat;
, no need to set this, it should be using default behavior which isrepeat
to be more predictable.text-decoration: inherit
;text-decoration
property used in those elements:a, s, u, del, ins, strike
and there is no need to set the inheritance over::before, ::after
, same forvertical-align: inherit
.cursor: default
in most elementscursor: default
is a default value and another things likecursor: auto
forinput, textarea
, so it's no need to set up, let the browser do its thing.In
abbr[title]
there is 2 declarations indeed duplicated:underline
thenunderline dotted
as values,underline dotted
used by Firefox as default (so it should be used as only declaration):small
font-size: 80%
unneeded because it's font set it up 2 see:main.css
=font-size: .8em;
margin: 0
tobutton, input, select
elements: not needed becausebutton, margin
has no margin andinput[type="*"]
have some margins but not big numbers so something like Stack layout would be adorable and it wouldn't need us to set margin to 0. ( .stack>+{ margin-block-start: 1rem } )-webkit-appearance: button
should be avoided to use.border: 1px solid #a0a0a0
set forfieldset
to achieve "Change the inconsistent appearance in all browsers (opinionated)." but actually there is no inconsistency: see https://browserdefaultstyles.com/#fieldset default value isborder: groove 2px ThreeDFace
margin: 0
totextarea
: textarea has no margin by default: https://browserdefaultstyles.com/#textareainput[type="search"]
no need for those declarations because outline-offset is 0 by default see: https://browserdefaultstyles.com/#[type=search]In fact vendor specific things should be avoided...
:focus-visible
isn't needed but:target
is fine but no need forz-index: 2
summary
declaration is ok but it's better to use justsummary
and notdetails > summary:first-of-type
because website authors themselves shouldn't add more then one summary to details element and for not increasing specificity it's better to stick withsummary
.datalist { display: none }
unnecessary it's default see: https://browserdefaultstyles.com/#datalistThe text was updated successfully, but these errors were encountered: