Extract private methods re: password fields

Author: jaredbeck

.rubocop_todo.yml

@@ -26,7 +26,7 @@ Lint/SendWithMixinArgument:
 
 # Offense count: 3
 Metrics/AbcSize:
-  Max: 16.28
+  Max: 16.03
 
 # Offense count: 5
 Style/ClassVars:

lib/authlogic/session/base.rb

@@ -1617,15 +1617,23 @@ def define_login_field_methods
         self.class.send(:attr_reader, login_field) unless respond_to?(login_field)
       end
 
+      # @api private
       def define_password_field_methods
         return unless password_field
-        self.class.send(:attr_writer, password_field) unless respond_to?("#{password_field}=")
-        self.class.send(:define_method, password_field) {} unless respond_to?(password_field)
+        define_password_field_writer_method
+        define_password_field_reader_methods
+      end
 
-        # The password should not be accessible publicly. This way forms
-        # using form_for don't fill the password with the attempted
-        # password. To prevent this we just create this method that is
-        # private.
+      # The password should not be accessible publicly. This way forms using
+      # form_for don't fill the password with the attempted password. To prevent
+      # this we just create this method that is private.
+      #
+      # @api private
+      def define_password_field_reader_methods
+        unless respond_to?(password_field)
+          # Deliberate no-op method, see rationale above.
+          self.class.send(:define_method, password_field) {}
+        end
         self.class.class_eval(
           <<-EOS, __FILE__, __LINE__ + 1
             private
@@ -1636,6 +1644,12 @@ def protected_#{password_field}
         )
       end
 
+      def define_password_field_writer_method
+        unless respond_to?("#{password_field}=")
+          self.class.send(:attr_writer, password_field)
+        end
+      end
+
       # Creating an alias method for the "record" method based on the klass
       # name, so that we can do:
       #