Skip to content

Commit 9308ae5

Browse files
dagrhjuanquintela
authored andcommitted
migration: Fix seg with missing port
The command : migrate tcp:localhost: currently segs; fix it so it now says: error parsing address 'localhost:' and the same for -incoming. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
1 parent 5cf0f48 commit 9308ae5

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

migration/socket.c

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,12 @@ void tcp_start_outgoing_migration(MigrationState *s,
112112
const char *host_port,
113113
Error **errp)
114114
{
115-
SocketAddress *saddr = tcp_build_address(host_port, errp);
116-
socket_start_outgoing_migration(s, saddr, errp);
115+
Error *err = NULL;
116+
SocketAddress *saddr = tcp_build_address(host_port, &err);
117+
if (!err) {
118+
socket_start_outgoing_migration(s, saddr, &err);
119+
}
120+
error_propagate(errp, err);
117121
}
118122

119123
void unix_start_outgoing_migration(MigrationState *s,
@@ -174,8 +178,12 @@ static void socket_start_incoming_migration(SocketAddress *saddr,
174178

175179
void tcp_start_incoming_migration(const char *host_port, Error **errp)
176180
{
177-
SocketAddress *saddr = tcp_build_address(host_port, errp);
178-
socket_start_incoming_migration(saddr, errp);
181+
Error *err = NULL;
182+
SocketAddress *saddr = tcp_build_address(host_port, &err);
183+
if (!err) {
184+
socket_start_incoming_migration(saddr, &err);
185+
}
186+
error_propagate(errp, err);
179187
}
180188

181189
void unix_start_incoming_migration(const char *path, Error **errp)

0 commit comments

Comments
 (0)