-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0-beta.1: lint in subdirectory not using root .gitignore
#5440
Comments
Yeah, this isn't a bug. Full monorepo support hasn't been completed yet: #2228 |
I just tested this with |
@ValentinGurkov can you please provide a reproduction? |
Hello @ValentinGurkov, please provide a minimal reproduction. You can use one of the following options:
Issues marked with |
Any workaround that could work with the beta version? |
Use a top-level command to lint the whole monorepo. |
I have managed to create a minimal reproduction that can be found at https://github.com/ValentinGurkov/biome-repro-1742925348856. I have enabled one How to reproduce with the repository:
The report should only include errors for
The diagnostics also report errors for This regression could be related to how the Оr it could be that setup (root config and ignore file but package-specific command) worked by sheer chance on older versions and was never intended. I hope I managed to be of some help, this is my first time opening an issue here. |
I checked your reproduction, and it's possible that it worked by chance. It has a monorepo setting, which isn't supported at the moment. See #2228 As a workaround, lint the entire project from the root, and use overrides to tweak rules/etc. based on the project. Biome is fast, it shouldn't make too much of a difference. |
Environment information
What happened?
Running
biome check
for a subdirectory/package in a monorepo does not use the.gitingore
file from the project root. I noticed the command taking forever and figured it was due to it formatting my Next.js output folder.next
.I created a
.gitignore
for the subdirectory and the process took 109ms.The output folder is ignored this way in the root
.gitignore
:Expected result
While I am not 100% everyone would consider this a bug, ESLint in a monorepo scenario can work with a single
.gitingore
file at the project root, so I expected the same here.Version
1.9.4
also uses the root.gitignore
correctly.Reproduction
https://github.com/ValentinGurkov/biome-repro-1742925348856
Code of Conduct
The text was updated successfully, but these errors were encountered: