Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple columns per condition for boxpoints #47

Open
carrascomj opened this issue Mar 5, 2024 · 0 comments
Open

Multiple columns per condition for boxpoints #47

carrascomj opened this issue Mar 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@carrascomj
Copy link
Member

Why

Feedback from people at UQ: we would like to have multiple columns to represent point estimates of different nature (transcriptomics/protemics) or multiple replicates for the same data and condition (or isozymes, etc.) for a particular reaction.

What

Given the following figure:

image
(From Valgepea et al., 2018)

We would like the same but inverting rows and columns.

How

ggshu geom.boxpoint() would now also take a x aes that would identify the column. The API would be something like:

(
        ggshu.ggmap(
            df_reac,
            ggshu.aes(reaction="reaction", color="mM", condition="condition", x="isozyme"),
        )
        + ggshu.geom_boxpoint())
    )

shu would now accept a box_x field:

pub struct Data {
// ...
    /// Decide the column of the boxpoint.
    box_x: Option<Vec<String>>,
// ...
}

Then each entity with Aesthetics, GeomHist and Point<f32> should be spawned with a Column component containing Vec<Option<String>>. This would be accumulated per axis in the build_point_axes with a similar logic than that of conditions. plot_box_point will need to account for the new x coordinate.

As a nice to have, the tag of each column should be put on top of the column ($\pi/2$ if more than two letters), although immediate readability should not be prioritized in this case.

@carrascomj carrascomj added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant