New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Known issues regarding the implementation #1

Open

ghost opened this issue Oct 6, 2021 · 1 comment

ghost commented Oct 6, 2021

The following are some problems with the code I noticed while I was looking through the code.

Paddings should be added during inference stage.
https://github.com/d9n13lt4n/rcgan-pytorch/blob/2dfc9ef19850fa5d1b4159a82a4d890a8b2860c8/models/utils.py#L302
This loss calculation is not calculated w.r.t. sequence length and should ignore paddings.
https://github.com/d9n13lt4n/rcgan-pytorch/blob/2dfc9ef19850fa5d1b4159a82a4d890a8b2860c8/models/rgan.py#L189

Author

ghost commented Oct 6, 2021

These issues have not been resolved as of now. Might take awhile to resolve as I have other things to settle.
Feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment