Skip to content

fw should only report a found block if share was submitted and accepted #1552

@0xf0xx0

Description

@0xf0xx0

Describe the bug
the firmware seems to treat valid shares as found blocks, even if the share was never submitted to the pool.

To Reproduce
Steps to reproduce the behavior:

  1. Set up a regtest node
  2. Set up a pool pointing to it with a high difficulty (10k is plenty, 25k at most)
  3. mine on it with your axe
  4. watch the "block found" banner pop up even though no shares were submitted to the pool

Expected behavior
I expected the block found banner to appear only with submitted shares.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions