Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Feature: Next Transition functionality should be better encapsulated #67

Open
arikorn opened this issue Feb 11, 2025 · 0 comments

Comments

@arikorn
Copy link

arikorn commented Feb 11, 2025

Currently every nextTransition action/state/feedback needs to "know" the internal representation of GSD communication protocol. This can lead to both awkward and "brittle" code. Instead, the nextTransition group could be encapsulated as a class with functions to manage the key states in a more generic fashion.

I've already done this on my local repo and will submit with the PR addressing NextTransition issues.
Including Issues #45 #54 #55 and #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant